test_runner: graceful termination on --test only#43977
Merged
nodejs-github-bot merged 9 commits intonodejs:mainfrom Jul 27, 2022
Merged
test_runner: graceful termination on --test only#43977nodejs-github-bot merged 9 commits intonodejs:mainfrom
--test only#43977nodejs-github-bot merged 9 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
Member
Author
|
@nodejs/test_runner |
aduh95
reviewed
Jul 25, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Jul 25, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
MoLow
commented
Jul 25, 2022
| const test = require('node:test'); | ||
|
|
||
| test('never ending test', () => { | ||
| while (true) { |
Linkgoron
approved these changes
Jul 25, 2022
aduh95
reviewed
Jul 25, 2022
aduh95
reviewed
Jul 25, 2022
aduh95
reviewed
Jul 25, 2022
benjamingr
reviewed
Jul 25, 2022
benjamingr
approved these changes
Jul 25, 2022
aduh95
reviewed
Jul 25, 2022
Collaborator
Collaborator
16 tasks
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/43977 ✔ Done loading data for nodejs/node/pull/43977 ----------------------------------- PR info ------------------------------------ Title test_runner: graceful termination on `--test` only (#43977) Author Moshe Atlow (@MoLow) Branch MoLow:graceful-exit-on-test-runner-only -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x, commit-queue-squash, test_runner Commits 9 - test_runner: graceful termination on `--test` only - Update lib/internal/test_runner/harness.js - fix test - test infinate loop - lint - CR - cr - fix windows - CR Committers 2 - Moshe Atlow - GitHub PR-URL: https://github.com/nodejs/node/pull/43977 Reviewed-By: Antoine du Hamel Reviewed-By: Nitzan Uziely Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43977 Reviewed-By: Antoine du Hamel Reviewed-By: Nitzan Uziely Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 25 Jul 2022 06:56:31 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43977#pullrequestreview-1050874149 ✔ - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/43977#pullrequestreview-1050862651 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/43977#pullrequestreview-1049287575 ✖ This PR needs to wait 11 more minutes to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-26T16:21:52Z: https://ci.nodejs.org/job/node-test-pull-request/45690/ - Querying data for job/node-test-pull-request/45690/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2744686060 |
nodejs-github-bot
added
the
commit-queue-failed
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 26e2742 |
This was referenced Aug 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this addresses feedback from #43549 (comment)
when running
--testthe event loop is not supposed to be blocked since it (noramlly) does not run user-land code,so it is fairly safe to hook on
SIGTERM/SIGINTin this case without riskingctr+cnot working