util: use string width in util formatPrimitive() string length line check

[Anemy]

Improves support for util.inspect formatting strings with unicode characters by updating to look at the string width instead of the string length.

Characters like あ have a width of 2 and length 1.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45167/

[BridgeAR]

I would like to run a benchmark on this to make sure the performance hit is not too big.

Benchmark: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1162/

[BridgeAR]

Let's wait until our benchmarks are fixed.

[BridgeAR]

This does slow down printing strings significantly (only 2 stars and more):

17:14:46 util/format.js type='only-objects' n=100000                                                            **     -3.85 %       ±2.31% ±3.07%  ±3.98%
17:14:46 util/inspect-array.js type='denseArray' len=100 n=500                                                  **     -6.02 %       ±3.97% ±5.27%  ±6.81%
17:14:46 util/inspect-array.js type='denseArray_showHidden' len=100 n=500                                      ***     -8.34 %       ±4.14% ±5.50%  ±7.13%
17:14:46 util/inspect.js option='colors' method='Object_deep_ln' n=20000                                       ***     -5.35 %       ±1.80% ±2.39%  ±3.09%
17:14:46 util/inspect.js option='colors' method='Object' n=20000                                               ***     -5.80 %       ±2.90% ±3.85%  ±4.98%
17:14:46 util/inspect.js option='colors' method='String_boxed' n=20000                                          **     -6.64 %       ±4.01% ±5.32%  ±6.88%
17:14:46 util/inspect.js option='colors' method='String_complex' n=20000                                       ***    -14.84 %       ±3.98% ±5.27%  ±6.82%
17:14:46 util/inspect.js option='colors' method='String' n=20000                                               ***    -19.74 %       ±5.09% ±6.75%  ±8.73%
17:14:46 util/inspect.js option='none' method='Object_deep_ln' n=20000                                          **     -3.24 %       ±2.03% ±2.69%  ±3.48%
17:14:46 util/inspect.js option='none' method='String_complex' n=20000                                         ***    -12.09 %       ±4.06% ±5.38%  ±6.96%
17:14:46 util/inspect.js option='none' method='String' n=20000                                                 ***    -14.73 %       ±4.50% ±5.97%  ±7.72%
17:14:46 util/inspect.js option='showHidden' method='Error' n=20000                                            ***     -5.24 %       ±2.33% ±3.09%  ±4.01%
17:14:46 util/inspect.js option='showHidden' method='String_complex' n=20000                                    **     -6.10 %       ±4.30% ±5.69%  ±7.36%
17:14:46 util/inspect.js option='showHidden' method='String' n=20000                                           ***    -11.18 %       ±3.65% ±4.84%  ±6.26%

I wonder if we really want this by default. We do not profit from it strongly as it is only going to be used for formatting things nicer under very special circumstances. I already feared the performance drop when I wrote the comment and did not implement it at that point due to that.
By now, I believe it is be best to just accept some input to be formatted slightly different to have a better average performance.

[BridgeAR]

I suggest to just remove the comment instead to prevent the slowdown in the average case.

[Anemy]

@BridgeAR Thanks for running the benchmarks! Totally agree, removed the TODO in a separate pr: #43762
Closing this, I can alternatively reopen and do the change in this pr if that's better.