test_runner: wait for stderr and stdout to complete#43666
test_runner: wait for stderr and stdout to complete#43666nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
2536e4f to
7ef9c56
Compare
7ef9c56 to
97b5953
Compare
97b5953 to
b82a40f
Compare
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Commit Queue failed- Loading data for nodejs/node/pull/43666 ✔ Done loading data for nodejs/node/pull/43666 ----------------------------------- PR info ------------------------------------ Title test_runner: wait for stderr and stdout to complete (#43666) Author Moshe Atlow (@MoLow) Branch MoLow:test-runner-attempt-fixing-flaky-test -> nodejs:main Labels needs-ci, test_runner Commits 2 - test_runner: wait for stderr and stdout to complete - Apply suggestions from code review Committers 2 - Moshe Atlow - GitHub PR-URL: https://github.com/nodejs/node/pull/43666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43666 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 03 Jul 2022 09:59:50 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/43666#pullrequestreview-1027872861 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43666#pullrequestreview-1028257215 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-08T07:51:08Z: https://ci.nodejs.org/job/node-test-pull-request/45150/ - Querying data for job/node-test-pull-request/45150/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 43666 From https://github.com/nodejs/node * branch refs/pull/43666/merge -> FETCH_HEAD ✔ Fetched commits as f3a92a0572b1..e48d3eccbd6c -------------------------------------------------------------------------------- [main 83c342419f] test_runner: wait for stderr and stdout to complete Author: Moshe Atlow Date: Sun Jul 3 12:57:29 2022 +0300 1 file changed, 4 insertions(+), 1 deletion(-) [main 96fffa486f] Apply suggestions from code review Author: Moshe Atlow Date: Mon Jul 4 23:45:19 2022 +0300 1 file changed, 2 insertions(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/2635335874 |
|
Landed in e1ab9dc |
|
Thanks you @MoLow |
Sure. I hope this will fix the issue |
PR-URL: nodejs/node#43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs/node#43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs/node#43666 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
this is an attempt to fix #43618