Skip to content

doc: remove lttng from tierlist#43604

Closed
tony-go wants to merge 1 commit intonodejs:mainfrom
tony-go:remove-lttng-tierlist
Closed

doc: remove lttng from tierlist#43604
tony-go wants to merge 1 commit intonodejs:mainfrom
tony-go:remove-lttng-tierlist

Conversation

@tony-go
Copy link
Member

@tony-go tony-go commented Jun 28, 2022

Hey 👋

Context

The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.

Note: it's normally the last batch of updates before closing the issue.

Updated

In the previous instance, we examined the case of the LTTng module: issue link.

As anyone in the instance has an idea about a potential usage in the field, we decided to remove it. As said in the previous PRs, we prefer to have a list that contains fewer items but is trustable.

But in case you have a different opinion, please share your thoughts in this PR 🙏.

Discuss

As usual, feel free to share your thoughts on that and your experience with this tool.

With love ❤️

cc @nodejs/diagnostics

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 28, 2022

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2022
bnoordhuis
bnoordhuis approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the record: lttng support was removed in 2018 in commit 30fd3d2 and was broken (as in: didn't build) since 2016.

@tony-go
Copy link
Member Author

tony-go commented Jun 30, 2022

LGTM. For the record: lttng support was removed in 2018 in commit 30fd3d2 and was broken (as in: didn't build) since 2016.

Hey make sense.

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 30, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 30, 2022

Commit Queue failed
- Loading data for nodejs/node/pull/43604
✔  Done loading data for nodejs/node/pull/43604
----------------------------------- PR info ------------------------------------
Title      doc: remove lttng from tierlist (#43604)
Author     Tony Gorez  (@tony-go)
Branch     tony-go:remove-lttng-tierlist -> nodejs:main
Labels     doc
Commits    1
 - doc: remove lttng from tierlist
Committers 1
 - Tony Gorez 
PR-URL: https://github.com/nodejs/node/pull/43604
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
Reviewed-By: Gerhard Stöbich 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43604
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
Reviewed-By: Gerhard Stöbich 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 28 Jun 2022 19:17:30 GMT
   ✔  Approvals: 4
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023135322
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023382545
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023408203
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023940228
   ✖  This PR needs to wait 7 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2589812099

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 30, 2022
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 1, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2022

Commit Queue failed
- Loading data for nodejs/node/pull/43604
✔  Done loading data for nodejs/node/pull/43604
----------------------------------- PR info ------------------------------------
Title      doc: remove lttng from tierlist (#43604)
Author     Tony Gorez  (@tony-go)
Branch     tony-go:remove-lttng-tierlist -> nodejs:main
Labels     doc, author ready
Commits    1
 - doc: remove lttng from tierlist
Committers 1
 - Tony Gorez 
PR-URL: https://github.com/nodejs/node/pull/43604
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43604
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 28 Jun 2022 19:17:30 GMT
   ✔  Approvals: 5
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023135322
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023382545
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023408203
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023940228
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43604#pullrequestreview-1026590298
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 43604
From https://github.com/nodejs/node
 * branch                  refs/pull/43604/merge -> FETCH_HEAD
✔  Fetched commits as 2bd940c0cb59..bcafde91ba73
--------------------------------------------------------------------------------
Auto-merging doc/contributing/diagnostic-tooling-support-tiers.md
CONFLICT (content): Merge conflict in doc/contributing/diagnostic-tooling-support-tiers.md
error: could not apply bcafde91ba... doc: remove lttng from tierlist
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
   ✖  Failed to apply patches
https://github.com/nodejs/node/actions/runs/2598812931

@RafaelGSS
Copy link
Member

RafaelGSS commented Jul 1, 2022

@tony-go can you resolve conflicts?

@tony-go tony-go force-pushed the remove-lttng-tierlist branch from bcafde9 to 52b0dac Compare July 2, 2022 18:45
@tony-go
Copy link
Member Author

tony-go commented Jul 2, 2022

Rebased ↪️

@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 2, 2022

Commit Queue failed
- Loading data for nodejs/node/pull/43604
✔  Done loading data for nodejs/node/pull/43604
----------------------------------- PR info ------------------------------------
Title      doc: remove lttng from tierlist (#43604)
Author     Tony Gorez  (@tony-go)
Branch     tony-go:remove-lttng-tierlist -> nodejs:main
Labels     doc, author ready
Commits    1
 - doc: remove lttng from tierlist
Committers 1
 - Tony Gorez 
PR-URL: https://github.com/nodejs/node/pull/43604
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43604
Reviewed-By: Ben Noordhuis 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - doc: remove lttng from tierlist
   ℹ  This PR was created on Tue, 28 Jun 2022 19:17:30 GMT
   ✔  Approvals: 5
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023135322
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023382545
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023408203
   ✔  - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023940228
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43604#pullrequestreview-1026590298
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2602972466

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 2, 2022
lpinca pushed a commit that referenced this pull request Jul 3, 2022
@tony-go @lpinca
doc: remove lttng from tierlist
85fb533 
PR-URL: #43604
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Jul 3, 2022

Landed in 85fb533.

@lpinca lpinca closed this Jul 3, 2022
@tony-go tony-go deleted the remove-lttng-tierlist branch July 5, 2022 11:05
targos pushed a commit that referenced this pull request Jul 12, 2022
@tony-go @targos
doc: remove lttng from tierlist
a6e98df 
PR-URL: #43604
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@tony-go @targos
doc: remove lttng from tierlist
79faef2 
PR-URL: #43604
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tony-go @targos
doc: remove lttng from tierlist
d514ee7 
PR-URL: #43604
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tony-go @guangwong
doc: remove lttng from tierlist
6cd2b9b 
PR-URL: nodejs/node#43604
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@lpinca lpinca lpinca approved these changes

@Flarna Flarna Flarna approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tony-go @nodejs-github-bot @RafaelGSS @lpinca @bnoordhuis @Flarna @RaisinTen @aduh95