events: improve EventListener validation#43491
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 29, 2022
Merged
Conversation
This fixes validating `EventListener` given to `add/removeEventListener` to improve the Web API compatibility. According to the WPT test failure with the current validation, `addEventListener` should not require `handleEvent` to be defined on an `EventListener`". IIUC, the same can be applied to `removeEventListener` also. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
benjamingr
approved these changes
Jun 20, 2022
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
You learn something new every day, had no idea this works.
Thanks for the fix.
benjamingr
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Member
Author
|
@benjamingr Thanks for your kind feedback. :-) |
33 tasks
Collaborator
This was referenced Jun 22, 2022
lpinca
approved these changes
Jun 23, 2022
This was referenced Jun 24, 2022
jasnell
approved these changes
Jun 27, 2022
Ayase-252
added
the
author ready
Collaborator
23 tasks
Collaborator
benjamingr
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ed1e9ae |
Member
|
Congrats 🎉 |
Member
Author
|
Thank you @benjamingr and thank you all! |
mabaasit
pushed a commit
to mabaasit/node
that referenced
this pull request
Jul 6, 2022
This fixes validating `EventListener` given to `add/removeEventListener` to improve the Web API compatibility. According to the WPT test failure with the current validation, `addEventListener` should not require `handleEvent` to be defined on an `EventListener`". IIUC, the same can be applied to `removeEventListener` also. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs#43491 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This fixes validating `EventListener` given to `add/removeEventListener` to improve the Web API compatibility. According to the WPT test failure with the current validation, `addEventListener` should not require `handleEvent` to be defined on an `EventListener`". IIUC, the same can be applied to `removeEventListener` also. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43491 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
This fixes validating `EventListener` given to `add/removeEventListener` to improve the Web API compatibility. According to the WPT test failure with the current validation, `addEventListener` should not require `handleEvent` to be defined on an `EventListener`". IIUC, the same can be applied to `removeEventListener` also. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43491 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This fixes validating `EventListener` given to `add/removeEventListener` to improve the Web API compatibility. According to the WPT test failure with the current validation, `addEventListener` should not require `handleEvent` to be defined on an `EventListener`". IIUC, the same can be applied to `removeEventListener` also. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: #43491 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This fixes validating `EventListener` given to `add/removeEventListener` to improve the Web API compatibility. According to the WPT test failure with the current validation, `addEventListener` should not require `handleEvent` to be defined on an `EventListener`". IIUC, the same can be applied to `removeEventListener` also. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: nodejs/node#43491 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes validating
EventListenergiven toaddEventListenerto improve the compatibility.According to the WPT test result failed with the current validation,
addEventListenershould not require
handleEventto be defined on anEventListener. IIUC, the same canbe applied to
removeEventListeneralso.Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com