test: refactor to top-level await#43366
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Jun 19, 2022
Merged
Conversation
nodejs-github-bot
added
needs-ci
Member
Contributor
Author
Just 49967ef. I made the commit from the same branch. |
jasnell
approved these changes
Jun 12, 2022
Member
|
This seems to add |
Contributor
Author
Would you recommend closing this PR and opening a new one from a diff branch? |
Member
You can do that, but I would recommend these steps instead:
|
meekdenzo
force-pushed
the
test-debugger-extract-function-name-modify
branch
2 times, most recently
from
503e2f5 to
16d5942
Compare
Trott
approved these changes
Jun 16, 2022
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
31 tasks
Collaborator
34 tasks
Collaborator
Collaborator
Collaborator
Collaborator
Trott
force-pushed
the
test-debugger-extract-function-name-modify
branch
from
16d5942 to
fcb6136
Compare
github-actions
bot
removed
the
request-ci
Collaborator
30 tasks
Trott
approved these changes
Jun 19, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 94020ac |
This was referenced Jun 20, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 18, 2022
PR-URL: #43366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors to top-level
await.