build: fix format-cpp

[RaisinTen]

According to the logs in
#42681 (comment),
make format-cpp exits with an NZEC. This change intentionally ignores
the error code because it is irrelevant. We already check if the
formatter produced a diff in the next line.

Ignoring the make format-cpp error code works as expected: https://github.com/nodejs/node/runs/6054137816?check_suite_focus=true

Details

Formatting C++ diff from c3a581c360ca1a2a11e49e2e99ca9ea83bbbaaf9..
changed files:
    src/api/environment.cc
    src/env.h
    src/node_wasm_web_api.cc
    src/node_wasm_web_api.h
make: *** [Makefile:1437: format-cpp] Error 1
diff --git a/src/api/environment.cc b/src/api/environment.cc
index 02a4d8d2fc..f3a8f49812 100644
--- a/src/api/environment.cc
+++ b/src/api/environment.cc
@@ -255,7 +255,8 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
   isolate->SetAllowWasmCodeGenerationCallback(allow_wasm_codegen_cb);
 
   Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
-  if (per_process::cli_options->get_per_isolate_options()->get_per_env_options()
+  if (per_process::cli_options->get_per_isolate_options()
+          ->get_per_env_options()
           ->experimental_fetch) {
     isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
   }
diff --git a/src/env.h b/src/env.h
index 7885a96771..7e35833e45 100644
--- a/src/env.h
+++ b/src/env.h
@@ -552,7 +552,7 @@ constexpr size_t kFsStatsBufferLength =
   V(udp_constructor_function, v8::Function)                                    \
   V(url_constructor_function, v8::Function)                                    \
   V(wasm_streaming_compilation_impl, v8::Function)                             \
-  V(wasm_streaming_object_constructor, v8::Function)                           \
+  V(wasm_streaming_object_constructor, v8::Function)
 
 class Environment;
 struct AllocatedBuffer;
diff --git a/src/node_wasm_web_api.cc b/src/node_wasm_web_api.cc
index 8d7a58a9cd..3a333900c9 100644
--- a/src/node_wasm_web_api.cc
+++ b/src/node_wasm_web_api.cc
@@ -95,8 +95,8 @@ void WasmStreamingObject::Push(
   }
 
   // Forward the data to V8. Internally, V8 will make a copy.
-  obj->streaming_->OnBytesReceived(
-      static_cast<const uint8_t*>(bytes) + offset, size);
+  obj->streaming_->OnBytesReceived(static_cast<const uint8_t*>(bytes) + offset,
+                                   size);
   obj->wasm_size_ += size;
 }
 
@@ -150,7 +150,7 @@ void StartStreamingCompilation(
   // instantiateStreaming).
   v8::Local<v8::Function> impl = env->wasm_streaming_compilation_impl();
   CHECK(!impl.IsEmpty());
-  v8::Local<v8::Value> args[] = { obj, info[0] };
+  v8::Local<v8::Value> args[] = {obj, info[0]};
 
   // Hand control to the JavaScript implementation. It should never throw an
   // error, but if it does, we leave it to the calling V8 code to handle that
diff --git a/src/node_wasm_web_api.h b/src/node_wasm_web_api.h
index 659344e2b8..9f5fe86816 100644
--- a/src/node_wasm_web_api.h
+++ b/src/node_wasm_web_api.h
@@ -44,8 +44,7 @@ class WasmStreamingObject final : public BaseObject {
 // This is a v8::WasmStreamingCallback implementation that must be passed to
 // v8::Isolate::SetWasmStreamingCallback when setting up the isolate in order to
 // enable the WebAssembly.(compile|instantiate)Streaming APIs.
-void StartStreamingCompilation(
-    const v8::FunctionCallbackInfo<v8::Value>& args);
+void StartStreamingCompilation(const v8::FunctionCallbackInfo<v8::Value>& args);
 
 }  // namespace wasm_web_api
 }  // namespace node

ERROR: Please run:

  CLANG_FORMAT_START="$(git merge-base HEAD <target-branch-name>)" make format-cpp

to format the commits in your branch.
Error: Process completed with exit code 1.

Refs: #42681 (comment)
Signed-off-by: Darshan Sen raisinten@gmail.com

[Trott]

This does mean that if the formatter fails to run for some other reason, the workflow will still pass. Maybe that's OK, but mentioning it just in case.

[Trott]

This does mean that if the formatter fails to run for some other reason, the workflow will still pass. Maybe that's OK, but mentioning it just in case.

For example, if we ever change the command to make format-src but don't update it here, the workflow will still pass.

(Again, maybe this is OK. I just want to make sure it's a decision we're making and not something that is happening unintentionally.)

[RaisinTen]

For example, if we ever change the command to make format-src but don't update it here, the workflow will still pass.

I think that's also applicable in other places like

node/.github/workflows/linters.yml

Line 126 in c3a581c

make lint-py-build || true

, so it's probably fine IMO.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/42764
✔  Done loading data for nodejs/node/pull/42764
----------------------------------- PR info ------------------------------------
Title      build: fix format-cpp (#42764)
Author     Darshan Sen  (@RaisinTen)
Branch     RaisinTen:fix-format-cpp -> nodejs:master
Labels     meta, author ready, needs-ci
Commits    1
 - build: fix format-cpp
Committers 1
 - Darshan Sen 
PR-URL: https://github.com/nodejs/node/pull/42764
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42764
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 17 Apr 2022 13:13:24 GMT
   ✔  Approvals: 4
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/42764#pullrequestreview-943957984
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42764#pullrequestreview-943982897
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42764#pullrequestreview-943995036
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42764#pullrequestreview-944714674
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2192710123

[nodejs-github-bot]

Landed in 61fefe1