crypto: do not add undefined hash in webcrypto normalizeAlgorithm#42559
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom Apr 3, 2022
Merged
Conversation
Collaborator
|
Review requested:
|
Member
|
Looks like there are some related failures, could you take a look, please? |
Member
Author
Yeah i'm trying to figure out how to best debug wpt failures right now. |
panva
force-pushed
the
fix-undefined-hash-from-normalize
branch
from
b09d864 to
df21856
Compare
panva
force-pushed
the
fix-undefined-hash-from-normalize
branch
from
df21856 to
379b548
Compare
Collaborator
Collaborator
9 tasks
Member
|
A bit of an aside, but I've re-added the It's perhaps a bit confusingly named, but the |
Trott
approved these changes
Apr 2, 2022
panva
added
experimental
tniessen
approved these changes
Apr 2, 2022
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
Tiny nit: since the file being test is called util.js, consider renaming the test to test-webcrypto-util.js (instead of test-webcrypto-utils.js).
Collaborator
8 tasks
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 5d0eb10 |
This was referenced Apr 4, 2022
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
11 tasks
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
17 tasks
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42559 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every now and then, when working with node's WebCryptoAPI, I noticed that the key's algorithm had an
undefinedhash property that wasn't present at the time of importing/deriving/generating. This, while not affecting the functionality of webcrypto, is not expected. This PR fixes that.