Closed
Conversation
Member
Author
Member
Author
|
CI is green, only unrelated failures. |
Member
There was a problem hiding this comment.
Maybe add a check for clientSessions.length here?
Member
|
LGTM. Apropos the commit log: |
Member
|
LGTM. +1 to @bnoordhuis' comment regarding the commit log. |
Member
|
@nodejs/http ... I'm leaning towards semver-minor on this. thoughts? |
indutny
added a commit
that referenced
this pull request
Dec 12, 2015
Zero value of `maxCachedSessions` should disable TLS session caching in `https.Agent` PR-URL: #4252 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
Author
indutny
added
the
semver-minor
indutny
added a commit
that referenced
this pull request
Dec 15, 2015
Zero value of `maxCachedSessions` should disable TLS session caching in `https.Agent` PR-URL: #4252 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
cjihrig
added a commit
that referenced
this pull request
Dec 15, 2015
Notable changes:
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) #3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) #4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) #4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) #4276.
PR-URL: #4281
cjihrig
added a commit
that referenced
this pull request
Dec 16, 2015
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) #3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) #3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) #4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) #4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) #4276.
PR-URL: #4281
cjihrig
added a commit
that referenced
this pull request
Dec 16, 2015
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) #3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) #3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) #4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) #4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) #4276.
PR-URL: #4281
Conflicts:
src/node_version.h
|
@indutny would you explain me why we could/should disable session reuse? I don't see any production app use cases. |
Member
Author
|
@shouze there is one use case for the moment, and it is related to the #3940 . Basically session cache has an API problem, that is not fixed yet. So it is very practical to disable it when people want to see server certificates. I'm going to fix #3940, but nevertheless disabling session cache should be useful for testing and, probably, other use cases. Cheers! |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Zero value of `maxCachedSessions` should disable TLS session caching in `https.Agent` PR-URL: nodejs#4252 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) nodejs#3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) nodejs#3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) nodejs#4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) nodejs#4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) nodejs#4276.
PR-URL: nodejs#4281
Conflicts:
src/node_version.h
3 tasks
nicolas-moteau
added a commit
to Orange-OpenSource/node
that referenced
this pull request
Mar 6, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 6, 2019
PR-URL: nodejs#26433 Refs: nodejs#2228 Refs: nodejs#4252 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#26433 Refs: nodejs#2228 Refs: nodejs#4252 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if the could be any other description.
cc @nodejs/crypto