test: improve lib/internal/readline/promises.js coverage#42420
Merged
nodejs-github-bot merged 6 commits intonodejs:masterfrom Apr 3, 2022
Merged
test: improve lib/internal/readline/promises.js coverage#42420nodejs-github-bot merged 6 commits intonodejs:masterfrom
nodejs-github-bot merged 6 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Mar 21, 2022
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I think we can remove the test functions
Contributor
Author
|
@aduh95 I removed test function in response to take your suggestion, but test got following error. When use autoCommit option, readline write to stream in callback function of process.nextTick. If we removed test function, before readline write to stream and test assertion, invocation of |
Contributor
|
@fossamagna I suggest using |
using `await setImmediate` instead of `test` function + process.nextTick.
Contributor
Author
|
@aduh95 Thank you very much for your suggestion. |
aduh95
reviewed
Mar 24, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Mar 24, 2022
jasnell
approved these changes
Mar 25, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced Mar 27, 2022
Collaborator
8 tasks
Collaborator
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 95f94cf |
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#42420 Refs: https://coverage.nodejs.org/coverage-419f02ba1f00cac3/lib/internal/readline/promises.js.html Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42420 Refs: https://coverage.nodejs.org/coverage-419f02ba1f00cac3/lib/internal/readline/promises.js.html Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
17 tasks
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42420 Refs: https://coverage.nodejs.org/coverage-419f02ba1f00cac3/lib/internal/readline/promises.js.html Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Dependent of #37947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves a test coverage in
lib/internal/readline/promises.jsref: https://coverage.nodejs.org/coverage-419f02ba1f00cac3/lib/internal/readline/promises.js.html
This validates that
autoCommitoption work correctly.