doc: clarify that import also uses main#41720
Merged
nodejs-github-bot merged 5 commits intonodejs:masterfrom Jan 30, 2022
Merged
doc: clarify that import also uses main#41720nodejs-github-bot merged 5 commits intonodejs:masterfrom
nodejs-github-bot merged 5 commits intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
benmccann
force-pushed
the
main-import
branch
from
993e211 to
71775aa
Compare
benmccann
changed the title
GeoffreyBooth
approved these changes
Jan 27, 2022
Member
|
LGTM |
JakobJingleheimer
approved these changes
Jan 27, 2022
VoltrexKeyva
approved these changes
Jan 27, 2022
aduh95
requested changes
Jan 27, 2022
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Currently the link and the example only applies to require() (import does not support folders as modules).
I agree we should make it clearer that it defines the package entry point if there are no "exports" field, but maybe in a different paragraph.
Contributor
Author
|
Thanks for the review! I've attempted to reword it. Let me know what you think |
aduh95
reviewed
Jan 28, 2022
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Thanks for the new version. A few suggestions:
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Contributor
Author
|
done |
aduh95
approved these changes
Jan 28, 2022
aduh95
added
author ready
Mesteery
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 253f934 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41720 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs currently make it sound like
mainis only used when a package is included viarequire(). However, if youimporta package, it still uses themainfield