Skip to content

doc: fix async_hooks example in api docs#41609

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
marsonya:example-fix-async_hooks
Jan 21, 2022
Merged

doc: fix async_hooks example in api docs#41609
nodejs-github-bot merged 1 commit intonodejs:masterfrom
marsonya:example-fix-async_hooks

Conversation

@marsonya
Copy link
Member

@marsonya marsonya commented Jan 20, 2022

One of the Promise execution tracking examples
incorrectly requires exectionAsyncId instead of executionAsyncId

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jan 20, 2022
Ayase-252
Ayase-252 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@Ayase-252 Ayase-252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if commit lint problem gets fixed.

@marsonya
Copy link
Member Author

marsonya commented Jan 20, 2022

LGTM if commit lint problem gets fixed.

I did follow the doc: convention and the message title is short.
Is there something else I need to fix in the message?

Also, the commit-message-guidelines is not accessible at https://goo.gl/p2fr5Q as mentioned in the error.

@Ayase-252
Copy link
Member

Ayase-252 commented Jan 20, 2022

Error: not ok 4 line-length: Line should be <= 72 columns.

{
  found: 121,
  compare: '<=',
  wanted: 72,
  at: {
    line: 1,
    column: 72,
    body: [
      '',
      'One of the Promise execution tracking examples was incorrectly requireing `exectionAsyncId` instead of `executionAsyncId`'
    ]
  }
}

It looks like the commit body is too long.

@Ayase-252 Ayase-252 added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2022

Fast-track has been requested by @Ayase-252. Please 👍 to approve.

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit ef35175 into nodejs:master Jan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 21, 2022

Landed in ef35175

BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@marsonya @BethGriggs
doc: fix async_hooks example in api docs
86272ca 
PR-URL: #41609
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@marsonya @Linkgoron
doc: fix async_hooks example in api docs
25277a4 
PR-URL: nodejs#41609
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@marsonya @danielleadams
doc: fix async_hooks example in api docs
6b1a074 
PR-URL: #41609
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@marsonya @danielleadams
doc: fix async_hooks example in api docs
e3d1116 
PR-URL: #41609
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@marsonya @danielleadams
doc: fix async_hooks example in api docs
7a197ed 
PR-URL: #41609
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@marsonya @danielleadams
doc: fix async_hooks example in api docs
5d94bc6 
PR-URL: #41609
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ayase-252 Ayase-252 Ayase-252 approved these changes

+1 more reviewer

@Mesteery Mesteery Mesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marsonya @Ayase-252 @nodejs-github-bot @Mesteery