tool: Fixed bug causing JSON format to be broken#41565
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Mar 31, 2022
Merged
tool: Fixed bug causing JSON format to be broken#41565nodejs-github-bot merged 1 commit intonodejs:masterfrom
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Conversation
1d07a99 to
0d7ce77
Compare
jasnell
approved these changes
Jan 17, 2022
Collaborator
Collaborator
28 tasks
Collaborator
20 tasks
Contributor
Author
|
Need help. |
Contributor
Author
|
@aduh95 |
Collaborator
Collaborator
Collaborator
|
Landed in 605a01b |
Contributor
Author
|
@aduh95 |
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#41565 Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #41565 Reviewed-By: James M Snell <jasnell@gmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#41565 Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #41565 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #41565 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #41565 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #41565 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #41565 Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#41565 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON format in the current version of the
config.gypifile can be broken because thepprint.pformatfunction splits the argument string into multiple lines if it is long enough and contains SpacesYou can see that function
pprint.pformataccidentally splits the string into two lines, causing the JSON format to be brokenI can think of three solutions
1 Abandon the line length limit
2 Use regular matches after
pprint.pformat3 Manually implement an appropriate print function
I chose the simplest solution for this PR and am glad to work on other solutions if the administrator thinks it is necessary