meta: move one or more TSC members to emeritus#41466
meta: move one or more TSC members to emeritus#41466nodejs-github-bot wants to merge 1 commit intomasterfrom
Conversation
VoltrexKeyva
left a comment
There was a problem hiding this comment.
RaisinTen was recently added as a TSC member so this one was triggered on a bad time. :^)
|
@Trott FYI - I think the automation needs to be updated to handle people who just joined. |
It's supposed to compare the README from 3 months ago with the current README and ignore any TSC members that aren't listed in both versions of the README. Obviously, there's a bug in that code. 🙃 |
|
Here's the relevant code block: // Get current TSC members, then get TSC members at start of period. Only check
// TSC members who are on both lists. This way, we don't flag someone who has
// only been on the TSC for a week and therefore hasn't attended any meetings.
const tscMembersAtEnd = await getTscFromReadme();
await runGitCommand(`git checkout 'HEAD@{${SINCE}}' -- README.md`);
const tscMembersAtStart = await getTscFromReadme();
await runGitCommand('git reset HEAD README.md');
await runGitCommand('git checkout -- README.md');
const tscMembers = tscMembersAtEnd.filter(
(memberAtEnd) => tscMembersAtStart.includes(memberAtEnd)
);I'll start debugging and figure it out later, but putting this here in case someone wants to get a jump on it and beat me to it. :-D |
|
I believe the problem is that the workflow is doing a shallow checkout. Fix (I think/hope) is in #41472. |
Refs: nodejs#41466 PR-URL: nodejs#41472 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: nodejs#41466 PR-URL: nodejs#41472 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: nodejs#41466 PR-URL: nodejs#41472 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
This PR was generated by tools/find-inactive-tsc.yml.
@nodejs/tsc @RaisinTen
Since 3 months ago, RaisinTen attended 1 out of 10 meetings and voted in 0 of 2 votes.