Skip to content

doc: feature management proposal#41420

Closed
mhdawson wants to merge 4 commits intonodejs:masterfrom
mhdawson:features
Closed

doc: feature management proposal#41420
mhdawson wants to merge 4 commits intonodejs:masterfrom
mhdawson:features

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jan 6, 2022

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 6, 2022
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
bnb
bnb reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
VoltrexKeyva
VoltrexKeyva reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
mscdex
mscdex reviewed Jan 6, 2022
View reviewed changes
@Trott
Copy link
Member

Trott commented Jan 7, 2022

If we're going to add a doc like this, we'll probably want to include a link to it in https://github.com/nodejs/node/blob/master/.github/ISSUE_TEMPLATE/2-feature-request.yml.

mhdawson
mhdawson commented Jan 7, 2022
View reviewed changes
@mhdawson
Copy link
Member Author

mhdawson commented Jan 7, 2022

@mscdex @bnb @aduh95 @Trott thanks for all the comments. I think I've addressed them all.

aduh95
aduh95 reviewed Jan 7, 2022
View reviewed changes
@mhdawson mhdawson mentioned this pull request Jan 13, 2022
Closed
jasnell
jasnell reviewed Jan 17, 2022
View reviewed changes
doc/guides/feature-request-management.md

## Automated feature request handling

Our experience is that most feature requests that are
Copy link
Member

@jasnell jasnell Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these line lengths so short? :-P

Copy link
Member Author

@mhdawson mhdawson Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer that to having to check each one for being too long :)

@Mesteery
Copy link
Contributor

Mesteery commented Jan 19, 2022

Should this be moved to doc/contributing instead of doc/guides?

@mhdawson
Copy link
Member Author

mhdawson commented Jan 20, 2022

@Mesteery not that the other PR has landed this does need a "rebase"

@mhdawson
doc: feature management proposal
142caa2 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: nodejs#41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
Copy link
Member Author

mhdawson commented Jan 24, 2022

@Mesteery moved.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 28, 2022

@targos just wondering if you'd had a chance to consider what updates we might make to this in order to incorporate your suggestion about using Node.js feature requests

@targos
Copy link
Member

targos commented Jan 29, 2022

@mhdawson I think this PR doesn't have to wait for this project. I'm convinced that it will be useful but I need to discuss with other people before documenting it.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 31, 2022

@targos thanks. @nodejs/tsc it would be good to have a few more approvals since once this lands I'll work to turn on stale bot and we'll have some issues tagged feature being closed as outline in the process.

Trott
Trott reviewed Feb 1, 2022
View reviewed changes
@mhdawson @Trott
Update .github/ISSUE_TEMPLATE/2-feature-request.yml
467d1b6 
Co-authored-by: Rich Trott <rtrott@gmail.com>
RaisinTen
RaisinTen approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: HEAD links :)

mhdawson and others added 2 commits February 1, 2022 17:34
@mhdawson @RaisinTen
Update doc/contributing/feature-request-management.md
a378978 
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@mhdawson @RaisinTen
Update doc/contributing/feature-request-management.md
da1e6a4 
Co-authored-by: Darshan Sen <raisinten@gmail.com>
mcollina
mcollina approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson
Copy link
Member Author

mhdawson commented Feb 3, 2022 •
edited
Loading

Agreed in last weeks TSC meeting on actions, does still need to be on agenda? - Wrong PR

mhdawson added a commit that referenced this pull request Feb 4, 2022
@mhdawson
doc: feature management proposal
6c0eb94 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@mhdawson
Copy link
Member Author

mhdawson commented Feb 4, 2022

Landed in 6c0eb94

@mhdawson mhdawson closed this Feb 4, 2022
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@mhdawson @ruyadorno
doc: feature management proposal
451f333 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@mhdawson @danielleadams
doc: feature management proposal
1334f61 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@mhdawson @danielleadams
doc: feature management proposal
8567aff 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@mhdawson @danielleadams
doc: feature management proposal
b3134db 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: nodejs#41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@mhdawson @danielleadams
doc: feature management proposal
6be94bf 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: nodejs#41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@mhdawson @danielleadams
doc: feature management proposal
4472527 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@mhdawson @danielleadams
doc: feature management proposal
c742a1c 
Refs: https://github.com/nodejs/node/discussions/40823
Refs: #41113

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41420
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb left review comments

@Trott Trott Trott left review comments

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

+2 more reviewers

@mscdex mscdex mscdex left review comments

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.