test: mark test-worker-take-heapsnapshot flaky#41253
Closed
mhdawson wants to merge 2 commits intonodejs:masterfrom
Closed
test: mark test-worker-take-heapsnapshot flaky#41253mhdawson wants to merge 2 commits intonodejs:masterfrom
mhdawson wants to merge 2 commits intonodejs:masterfrom
Conversation
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: nodejs#41204 Refs: nodejs#41209 Signed-off-by: Michael Dawson <mdawson@devrus.com>
nodejs-github-bot
added
needs-ci
Member
Author
|
Would like to request a fast track on this. |
Contributor
|
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
Collaborator
cjihrig
approved these changes
Dec 21, 2021
jasnell
approved these changes
Dec 21, 2021
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Collaborator
Collaborator
21 tasks
Collaborator
Collaborator
Collaborator
Member
Author
|
Landed in 96a6326 |
This was referenced Dec 23, 2021
This was referenced Dec 30, 2021
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
- Mark test-worker-take-heapsnapshot as flaky on arm with debug Refs: nodejs#41204 Refs: nodejs#41209 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#41253 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arm with debug
Refs: #41204
Refs: #41209
Signed-off-by: Michael Dawson mdawson@devrus.com