meta: remove use of profanity in source#4122
meta: remove use of profanity in source#4122MylesBorins merged 1 commit intonodejs:masterfrom MylesBorins:merde
Conversation
|
LGTM |
1 similar comment
|
LGTM |
mscdex
added
dns
|
LGTM |
The CoC requests to avoid the casual use of profanity. PR-URL: #4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in b619831 |
|
@thealphanerd By choosing this branch name, you added two occurrences of profanity to this repository (three if we count the notification sent to the #io.js IRC channel). As a result, the net effect of this PR is questionable. Please, don't choose such names for branches in the future, it makes the project look bad. Also, is there a way to make GitHub not show this branch name in this repository? |
|
I apologize for the lapse of judgement it will not happen again. AFAIK there is no way to change the branch name in the PR |
The CoC requests to avoid the casual use of profanity. PR-URL: #4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
@thealphanerd I contacted GitHub's support, and it seems that if you delete your own fork of nodejs/node, the branch name will not be visible in this PR. Then you can re-fork nodejs/node, and as long as you don't re-create a branch with the same name, the branch name will still not be displayed in this PR. Can you please do that? |
|
@misterdjules done Thanks for following up |
|
@thealphanerd Excellent, thank you for your help, very much appreciated! 👍 |
The CoC requests to avoid the casual use of profanity. PR-URL: #4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
The CoC requests to avoid the casual use of profanity. PR-URL: #4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
The CoC requests to avoid the casual use of profanity. PR-URL: #4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
The CoC requests to avoid the casual use of profanity. PR-URL: nodejs#4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
5 participants
The CoC requests to avoid the casual use of profanity.