url,lib: pass urlsearchparams-constructor.any.js#41197
Closed
XadillaX wants to merge 1 commit intonodejs:masterfrom
Closed
url,lib: pass urlsearchparams-constructor.any.js#41197XadillaX wants to merge 1 commit intonodejs:masterfrom
XadillaX wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
jasnell
reviewed
Dec 17, 2021
| } | ||
|
|
||
| get code() { return 'ERR_INVALID_THIS'; } | ||
| function throwInvalidThisError(Base, type) { |
Member
There was a problem hiding this comment.
Is the change to domexception.js related to the urlsearchparams change? If it is, it's not clear how. Also, it would likely be better to separate this out into a separate commit in the PR if it is related.
Contributor
Author
There was a problem hiding this comment.
This modification is to pass urlsearchparams-contructor.any.js too.
Contributor
Author
There was a problem hiding this comment.
URLSearchParams constructor should throw exactly TypeError if any Error occurrs but not inheritance.
Contributor
Author
There was a problem hiding this comment.
aduh95
reviewed
Dec 18, 2021
XadillaX
force-pushed
the
urlsearchparams-constructor.any.js-2
branch
from
c2e77f2 to
c0a9720
Compare
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one.
XadillaX
force-pushed
the
urlsearchparams-constructor.any.js-2
branch
from
c0a9720 to
59e2c32
Compare
Contributor
Author
|
/ping @aduh95 |
Contributor
Author
|
@addaleax Hi Anna, would you please take a look at this PR? |
Contributor
Author
|
/cc @watilde |
Lxxyx
approved these changes
Dec 31, 2021
Collaborator
This was referenced Jan 5, 2022
Collaborator
Collaborator
Collaborator
Collaborator
XadillaX
added a commit
that referenced
this pull request
Jan 11, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: #41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Contributor
Author
|
Landed in 38b7961 |
Contributor
|
Did you mean: "Landed in 38b7961"? 😅 |
20 tasks
Contributor
Author
Yes. I think I copied the wrong text🙈 |
18 tasks
22 tasks
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: #41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
26 tasks
thedull
pushed a commit
to thedull/node
that referenced
this pull request
Jan 18, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: nodejs#41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: nodejs#41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: #41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
According to WPT: 1. `URLSearchParams` constructor should throw exactly `TypeError` if any Error occurrs. 2. When a record passed to `URLSearchParams` constructor, two different key may result same after `toUVString()`. We should leave only the later one. PR-URL: nodejs/node#41197 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to WPT:
URLSearchParamsconstructor should throw exactlyTypeErrorif anyError occurrs.
URLSearchParamsconstructor, two differentkey may result same after
toUVString(). We should leave only thelater one.