tools: ping TSC members identified as inactive#40915
tools: ping TSC members identified as inactive#40915nodejs-github-bot merged 3 commits intonodejs:masterfrom
Conversation
|
If we want to 100% make sure this works, we can fast-track it, close #40908, and let this open a PR. |
|
This lgtm, but it was mostly the next part of the message that I was interested in automating:
|
OK, I think this does something like that now. (I haven't tested it via an Action yet, but will run it when it lands and revise if necessary.) |
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error.
|
Landed in f7ac6ba |
|
https://github.com/nodejs/node/runs/4315947355?check_suite_focus=true The only nit would be to get rid of the |
I wonder if spaces aren't a problem in single-line |
|
I don't know for |
|
And if all else fails, we can use the multi-line HEREDOC format they support which doesn't require quotation marks or other punctuation around spaces. |
|
(Testing now on my fork.) |
|
Yup, leaving out the quotation marks worked. https://github.com/Trott/io.js/runs/4318829465?check_suite_focus=true (The failure is because I didn't set a needed token on my fork.) PR coming momentarily. |
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.