deps: update V8 to 9.7 by targos · Pull Request #40907 · nodejs/node

targos · 2021-11-21T16:10:30Z

ETA: Tue, Jan 4, 2022

Blog post: https://v8.dev/blog/v8-release-97

targos · 2021-11-22T08:17:46Z

@nodejs/platform-ppc PTAL: https://ci.nodejs.org/job/node-test-commit-v8-linux/4394/nodes=centos7-ppcle,v8test=v8test/

richardlau · 2021-11-22T12:19:13Z

@nodejs/platform-ppc PTAL: https://ci.nodejs.org/job/node-test-commit-v8-linux/4394/nodes=centos7-ppcle,v8test=v8test/

@targos maybe try rolling to 9.7.106.8 to pick up https://chromium.googlesource.com/v8/v8.git/+/5f980ae0c9c6539522383d6298f8363a34d7f52f?

targos · 2021-11-22T12:32:50Z

Done.

nodejs-github-bot · 2021-11-22T12:33:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41043/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4396/

targos · 2021-11-22T13:53:58Z

It looks like this update breaks JS code that was working before ?!?!

13:56:31 npm ERR! Cannot assign to read only property 'name' of function 'class CI extends ArboristWorkspaceCmd {
13:56:31 npm ERR!   static description = 'Install a project with a clean slate'
13:56:31 npm ERR!   static ...<omitted>...
13:56:31 npm ERR! }'

targos · 2021-11-22T14:51:01Z

~~I cannot reproduce this error on my machine.~~

Edit: rebasing to test with the latest npm.

miladfarca · 2021-11-22T14:55:10Z

@targos The V8 patch is PPC specific, but this error seems to be present on other platforms as well?
Built this PR on a PPC machine and couldn't reproduce this error either. Could you retry building in the CI?

targos · 2021-11-22T14:57:36Z

@miladfarca the PPC issue was fixed by 943c829

targos · 2021-11-22T15:00:24Z

The code that fails now is:

class X {
 static name = "name"
}

I can reproduce in Chrome canary:

@ljharb maybe you know if it's an expected spec change?

targos · 2021-11-22T16:04:46Z

I opened https://bugs.chromium.org/p/v8/issues/detail?id=12421

ljharb · 2021-11-22T16:06:43Z

No, class fields use Define, not Set, so the writability of Function names shouldn’t matter. Seems like a v8 bug.

nassau-t · 2021-11-23T10:58:44Z

The code that fails now is:
class X {
 static name = "name"
}

Only to comment, this works on Firefox.

bricss · 2022-01-18T09:53:47Z

I opened https://bugs.chromium.org/p/v8/issues/detail?id=12421

Looks like patch 🩹 is ready 👾

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 9.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#59045} Refs: v8/v8@bd019bd PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

We are not ready to migrate yet. Refs: #214 PR-URL: nodejs/node#40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

We are not ready to migrate yet. Refs: #214 PR-URL: nodejs/node#40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

We are not ready to migrate yet. Refs: #214 PR-URL: nodejs/node#40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

See: - babel/babel#14181 - https://bugs.chromium.org/p/v8/issues/detail?id=12421 - nodejs/node#40907

targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Nov 21, 2021

This comment has been minimized.

Sign in to view

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 21, 2021

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Nov 23, 2021

CI Reliability 2021-11-23 nodejs/reliability#126

Open

45 tasks

github-actions bot mentioned this pull request Nov 24, 2021

CI Reliability 2021-11-24 nodejs/reliability#127

Open

45 tasks

targos added the blocked PRs that are blocked by other issues or PRs. label Nov 24, 2021

This was referenced Nov 25, 2021

CI Reliability 2021-11-25 nodejs/reliability#128

Open

CI Reliability 2021-11-26 nodejs/reliability#129

Open

richardlau mentioned this pull request Dec 1, 2021

Error during npm install after installing canary nodejs/node-v8#216

Closed

hexchain mentioned this pull request Jan 17, 2022

`node --help' crashes inside qemu-user in 17.2.0 riscv-collab/v8#517

Closed

targos and others added 4 commits January 18, 2022 11:07

deps: update V8 to 9.7.106.18

9dc4c92

build: reset embedder string to "-node.0"

c534c2a

src: update NODE_MODULE_VERSION to 104

16e8671

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 9.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

JLHwung pushed a commit to JLHwung/compat-table that referenced this pull request Mar 30, 2023

add class fields test for chrome bug

303880e

See: - babel/babel#14181 - https://bugs.chromium.org/p/v8/issues/detail?id=12421 - nodejs/node#40907

Uh oh!

Conversation

targos commented Nov 21, 2021

Uh oh!

This comment has been minimized.

targos commented Nov 22, 2021

Uh oh!

This comment has been minimized.

richardlau commented Nov 22, 2021

Uh oh!

targos commented Nov 22, 2021

Uh oh!

nodejs-github-bot commented Nov 22, 2021 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Nov 22, 2021

Uh oh!

targos commented Nov 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miladfarca commented Nov 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Nov 22, 2021

Uh oh!

targos commented Nov 22, 2021

Uh oh!

targos commented Nov 22, 2021

Uh oh!

ljharb commented Nov 22, 2021

Uh oh!

nassau-t commented Nov 23, 2021

Uh oh!

bricss commented Jan 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

nodejs-github-bot commented Nov 22, 2021 •

edited by targos

Loading

targos commented Nov 22, 2021 •

edited

Loading

miladfarca commented Nov 22, 2021 •

edited

Loading