doc: add pref to using draft PR versus WIP label#40824
Merged
nodejs-github-bot merged 3 commits intonodejs:masterfrom Nov 19, 2021
Merged
doc: add pref to using draft PR versus WIP label#40824nodejs-github-bot merged 3 commits intonodejs:masterfrom
nodejs-github-bot merged 3 commits intonodejs:masterfrom
Conversation
- add to the contribution guide that we prefer that people use draft PRs instead of the WIP label. Signed-off-by: Michael Dawson <mdawson@devrus.com>
Member
Author
|
Based on discussion in #33309 |
tniessen
approved these changes
Nov 15, 2021
Member
|
If I recall correctly, GH actions do not run on draft PRs - so I've often had to revert to using the 'WIP' label so I can check the tests results of something that is still in progress (for example, the major release proposals). |
jasnell
approved these changes
Nov 16, 2021
Contributor
|
might be worth tracking this issue in the cli/cli repo (the official GitHub CLI) and updating these docs if that feature is ever shipped :) |
lpinca
approved these changes
Nov 16, 2021
Member
We could think about adding a new label to force run GH actions on draft PRs. |
Trott
reviewed
Nov 16, 2021
Trott
reviewed
Nov 16, 2021
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
ronag
reviewed
Nov 18, 2021
| To get feedback on your proposed change even though it is not ready | ||
| to land, use the `Convert to draft` option in the GitHub UI. | ||
| Do not use the `wip` label as it might not prevent the PR | ||
| from landing before you are ready. |
Member
There was a problem hiding this comment.
also I don't think wip stops GitHub ci from running
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 4a7a18b |
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
- add to the contribution guide that we prefer that people use draft PRs instead of the WIP label. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40824 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
- add to the contribution guide that we prefer that people use draft PRs instead of the WIP label. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40824 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
- add to the contribution guide that we prefer that people use draft PRs instead of the WIP label. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40824 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
people use draft PRs instead of the WIP label.
Signed-off-by: Michael Dawson mdawson@devrus.com