doc: use same link color in linked code blocks as in regular text links#4068
Closed
svenheden wants to merge 1 commit intonodejs:masterfrom
svenheden:doc/links-in-code-blocks
Closed
doc: use same link color in linked code blocks as in regular text links#4068svenheden wants to merge 1 commit intonodejs:masterfrom svenheden:doc/links-in-code-blocks
svenheden wants to merge 1 commit intonodejs:masterfrom
svenheden:doc/links-in-code-blocks
Conversation
Contributor
|
I like the change, but wouldn't a |
Author
|
Yeah that would also do it, if one prefers an override rule over the |
Contributor
|
Yeah, I think it's best to avoid |
Author
|
Updated and force pushed :) |
Contributor
|
Doesn't work here, looks like we need to increase specificity of that style. The options are a code {
color: inherit !important;
}#apicontent a code {
color: inherit;
}I think the first option is the way to go in case the container id ever changes, but I'll leave that up to you :) |
Contributor
|
Oh wait, it's working correctly. I live edited the wrong stylesheet so my rule came before the LGTM |
silverwind
pushed a commit
that referenced
this pull request
Nov 30, 2015
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: #4068 Reviewed-By: Roman Reiss <me@silverwind.io>
Contributor
|
Thanks! Landed in f4f1e89. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 1, 2015
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: #4068 Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Dec 4, 2015
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: #4068 Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Dec 5, 2015
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: #4068 Reviewed-By: Roman Reiss <me@silverwind.io>
This was referenced Dec 8, 2015
Closed
jasnell
pushed a commit
that referenced
this pull request
Dec 17, 2015
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: #4068 Reviewed-By: Roman Reiss <me@silverwind.io>
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2015
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: #4068 Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: nodejs#4068 Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's no way in the docs to visually distinguish a link in a code block from a non-linked code block.
This is how linked code blocks are styled today...
...and this is how linked code blocks are styled with this commit applied...