Skip to content

test: deflake http2-cancel-while-client-reading#40659

Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca:deflake/http2-cancel-while-client-reading
Closed

test: deflake http2-cancel-while-client-reading#40659
lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca:deflake/http2-cancel-while-client-reading

Conversation

@lpinca
Copy link
Member

@lpinca lpinca commented Oct 29, 2021

Add missing 'error' event handler.

Fixes: #40610

@lpinca
test: deflake http2-cancel-while-client-reading
3adca25 
Add missing `'error'` event handler.

Fixes: nodejs#40610
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 29, 2021
@lpinca
Copy link
Member Author

lpinca commented Oct 29, 2021 •
edited
Loading

This fixes the issue on my machine but I'm not sure if it invalidates the test.

cc: @nodejs/http2 @kumarak

@Mesteery Mesteery added the http2 Issues or PRs related to the http2 subsystem. label Oct 29, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 31, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40586/

This was referenced Nov 1, 2021
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 3, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40686/

mcollina
mcollina approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 3, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40691/

@github-actions github-actions bot mentioned this pull request Nov 4, 2021
Open
44 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40702/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40707/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Landed in 8fce09e...0a62026

@github-actions github-actions bot closed this Nov 4, 2021
nodejs-github-bot pushed a commit that referenced this pull request Nov 4, 2021
@lpinca @nodejs-github-bot
test: deflake http2-cancel-while-client-reading
0a62026 
Add missing `'error'` event handler.

Fixes: #40610

PR-URL: #40659
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@lpinca lpinca deleted the deflake/http2-cancel-while-client-reading branch November 4, 2021 19:33
This was referenced Nov 5, 2021
Open
Open
targos pushed a commit that referenced this pull request Nov 6, 2021
@lpinca @targos
test: deflake http2-cancel-while-client-reading
95fe9bb 
Add missing `'error'` event handler.

Fixes: #40610

PR-URL: #40659
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Nov 7, 2021
Open
Open
@targos targos mentioned this pull request Nov 8, 2021
Merged
@github-actions github-actions bot mentioned this pull request Nov 9, 2021
Open
23 tasks
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@lpinca @BethGriggs
test: deflake http2-cancel-while-client-reading
f114e35 
Add missing `'error'` event handler.

Fixes: #40610

PR-URL: #40659
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

+1 more reviewer

@kumarak kumarak kumarak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test - http2-cancel-while-client-reading

6 participants

@lpinca @nodejs-github-bot @mcollina @Trott @kumarak @Mesteery