tools: notify user if format-md needs to be run#40647
Merged
Trott merged 0 commit intonodejs:masterfrom Nov 2, 2021
Merged
Conversation
nodejs-github-bot
added
doc
Member
Author
|
Blocked on #40645 or at least blocked on the same things that that PR is blocked on. |
aduh95
reviewed
Oct 29, 2021
Trott
force-pushed
the
enforce-format-md
branch
from
4c0d31d to
46d25dd
Compare
aduh95
reviewed
Oct 30, 2021
aduh95
approved these changes
Oct 31, 2021
Trott
added
author ready
Trott
force-pushed
the
enforce-format-md
branch
from
28d5dcc to
076e03c
Compare
targos
approved these changes
Oct 31, 2021
Trott
force-pushed
the
enforce-format-md
branch
2 times, most recently
from
69808ca to
763c3d5
Compare
Trott
added a commit
that referenced
this pull request
Nov 2, 2021
PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott
added a commit
that referenced
this pull request
Nov 2, 2021
This will help enforce formatting of markdown files. PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott
force-pushed
the
enforce-format-md
branch
from
763c3d5 to
d4aca08
Compare
Member
Author
|
Landed in 6d0b4df...d4aca08 |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
This will help enforce formatting of markdown files. PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
If there is not a blank line before it, the comment does not re-enable the rule. PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 29, 2022
PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
This will help enforce formatting of markdown files. PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
If there is not a blank line before it, the comment does not re-enable the rule. PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
This will help enforce formatting of markdown files. PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
If there is not a blank line before it, the comment does not re-enable the rule. PR-URL: #40647 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit here is #40645 which will need to land first (or can be closed in favor of this PR).Make
lint-mdfail and tell the user to runformat-mdif they have misformatted markdown files.