deps: update V8 to 9.6 by targos · Pull Request #40488 · nodejs/node

targos · 2021-10-17T10:21:20Z

Blog post: https://v8.dev/blog/v8-release-96

ETA: Tue, Nov 16, 2021.

Diff in public V8 headers: https://gist.github.com/targos/fb358c24624eee2bf8b5350d39e852a0

nodejs-github-bot · 2021-10-17T10:24:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40335/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4333/

nodejs-github-bot · 2021-10-17T11:56:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40336/

targos · 2021-10-17T12:35:57Z

@nodejs/platform-windows-arm Can you please help with the build failure on arm64?

I tried to make our GYP config closer to the GN one, but it's still failing

4d1e094
https://ci.nodejs.org/job/node-compile-windows/42438/nodes=win-vs2019-arm64/console

14:25:53      Creating library ..\..\out\Release\mksnapshot_host.lib and object ..\..\out\Release\mksnapshot_host.exp
14:25:59 v8_base_without_compiler_host.lib(api.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::TryHandleWasmTrap(struct _EXCEPTION_POINTERS *)" (?TryHandleWasmTrap@trap_handler@internal@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) referenced in function "bool __cdecl v8::TryHandleWebAssemblyTrapWindows(struct _EXCEPTION_POINTERS *)" (?TryHandleWebAssemblyTrapWindows@v8@@YA_NPEAU_EXCEPTION_POINTERS@@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00 v8_base_without_compiler_host.lib(handler-outside.obj) : error LNK2019: unresolved external symbol "bool __cdecl v8::internal::trap_handler::RegisterDefaultTrapHandler(void)" (?RegisterDefaultTrapHandler@trap_handler@internal@v8@@YA_NXZ) referenced in function "bool __cdecl v8::internal::trap_handler::EnableTrapHandler(bool)" (?EnableTrapHandler@trap_handler@internal@v8@@YA_N_N@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00 v8_base_without_compiler_host.lib(simulator-arm64.obj) : error LNK2019: unresolved external symbol ProbeMemory referenced in function "protected: void __cdecl v8::internal::Simulator::LoadStoreHelper(class v8::internal::Instruction *,__int64,enum v8::internal::AddrMode)" (?LoadStoreHelper@Simulator@internal@v8@@IEAAXPEAVInstruction@23@_JW4AddrMode@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00     Hint on symbols that are defined and could potentially match:
14:26:00       "protected: bool __cdecl v8::internal::Simulator::ProbeMemory(unsigned __int64,unsigned __int64)" (?ProbeMemory@Simulator@internal@v8@@IEAA_N_K0@Z)
14:26:00 ..\..\out\Release\mksnapshot_host.exe : fatal error LNK1120: 3 unresolved externals [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot_host.vcxproj]
14:26:00

targos · 2021-10-19T04:21:33Z

I'm pretty sure the problem is that handler-outside-win.cc' is not being compiled, so something is wrong with the gyp condition.

nodejs-github-bot · 2021-10-19T04:41:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40360/

targos · 2021-10-19T11:22:47Z

I opened a V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=12327

targos · 2021-10-19T18:31:58Z

Trying a new build which will hopefully log the values of some macros: https://ci.nodejs.org/job/node-test-commit-windows-fanned/44944/

https://ci.nodejs.org/job/node-test-commit-windows-fanned/44945/

https://ci.nodejs.org/job/node-test-commit-windows-fanned/44946/

nodejs-github-bot · 2021-10-19T21:24:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40373/

nodejs-github-bot · 2021-10-19T21:52:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40374/

nodejs-github-bot · 2021-10-19T22:03:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40375/

targos · 2021-10-19T22:16:42Z

So, we've got a problem with gyp that I have no idea how to solve:

https://github.com/targos/node/blob/5dae1dba882f6ce71016a7b08f7f120e3015b342/tools/v8_gypfiles/v8.gyp#L871

With conditions, _toolset is not defined, because toolsets is defined conditionally (it has to be).
With target_conditions, _toolset is defined, but host_arch is not.

nodejs-github-bot · 2021-10-19T22:53:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40376/

nodejs-github-bot · 2021-10-20T06:29:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40379/

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs/node#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs/node#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs/node#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 17, 2021

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 17, 2021

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2021

This was referenced Oct 18, 2021

CI Reliability 2021-10-18 nodejs/reliability#90

Open

CI Reliability 2021-10-19 nodejs/reliability#91

Open

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2021

targos marked this pull request as draft October 19, 2021 18:18

targos force-pushed the v8-96 branch from ea98767 to 3805af4 Compare October 19, 2021 19:25

targos force-pushed the v8-96 branch from 632ca2b to 2f28851 Compare October 19, 2021 21:51

targos force-pushed the v8-96 branch from 2f28851 to 5dae1db Compare October 19, 2021 22:02

targos force-pushed the v8-96 branch from 5dae1db to b756cd2 Compare October 19, 2021 22:52

github-actions bot mentioned this pull request Oct 20, 2021

CI Reliability 2021-10-20 nodejs/reliability#92

Open

27 tasks

targos force-pushed the v8-96 branch from b756cd2 to cb72644 Compare October 20, 2021 06:28

krk mentioned this pull request Dec 30, 2022

Performance regression in Buffer.concat #45802

Closed

abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024

tools: update V8 gypfiles for 9.6

f101e43

PR-URL: nodejs/node#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced Jan 28, 2025

chore(deps): update node.js to v16.15.1 - autoclosed opalmedapps/docs#22

Closed

chore: update software packages (patch) opalmedapps/docs#27

Closed

Uh oh!

Conversation

targos commented Oct 17, 2021

Uh oh!

nodejs-github-bot commented Oct 17, 2021 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 17, 2021

Uh oh!

targos commented Oct 17, 2021

Uh oh!

targos commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

targos commented Oct 19, 2021

Uh oh!

targos commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

targos commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 19, 2021

Uh oh!

nodejs-github-bot commented Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nodejs-github-bot commented Oct 17, 2021 •

edited by targos

Loading

targos commented Oct 19, 2021 •

edited

Loading