meta: move one or more collaborators to emeritus by nodejs-github-bot · Pull Request #40464 · nodejs/node

nodejs-github-bot · 2021-10-15T04:12:13Z

This PR was generated by tools/find-inactive-collaborators.yml.

Trott · 2021-10-15T13:10:52Z

Our governance process is such that someone needs to either agree to be moved to emeritus or else the TSC has to act to move them to emeritus.

@yhwang Are you OK being moved to emeritus at this time?

Trott · 2021-10-15T13:12:29Z

Adding blocked and tsc-agenda labels. They can both be removed if yhwang approves the change.

tniessen · 2021-10-18T11:03:50Z

How did the second commit get here? GitHub marks it as "first-time contributor" and wants approval to run workflows. And then there is #40498 which appears to be a duplicate of this PR.

targos · 2021-10-18T11:49:57Z

The second commit is here because we have two different workflows that use the same branch name. See #40494
#40498 looks like spam or a mistake made by a new user.

Trott · 2021-10-19T13:45:11Z

I approve both commits. :-D

mhdawson

The change for openssl seems to just remove all of the licencing details. That seems wrong.

Trott · 2021-10-20T16:18:14Z

The change for openssl seems to just remove all of the licencing details. That seems wrong.

Ah, license-builder.sh needs an update. Coming in a few minutes, I think....

Trott · 2021-10-20T16:30:12Z

@mhdawson License update corrected. PTAL.

Trott · 2021-10-20T16:38:42Z

@yhwang Are you OK being moved to emeritus at this time?

@nodejs/tsc We've gotten no response so it looks like we're going to need TSC approval to remove @yhwang as a collaborator. Please approve (or block) this PR. Thanks!

cjihrig

The README changes LGTM.

richardlau · 2021-10-20T19:00:23Z

I think the openssl license updates should be separated -- they would make the PR need dont-land-on labels to prevent landing on the release lines that still contain openssl 1.1.1.

mhdawson · 2021-10-20T19:59:17Z

The README changes LGTM, but agree the change to the licence should be broken out into its own PR.

Trott · 2021-10-21T04:21:01Z

Fine, be all reasonable. I'll move the license change to a separate PR and then remove it from here.

Trott · 2021-10-21T04:24:04Z

License stuff moved to #40540. This PR is now just the automated collaborator change.

mhdawson

LGTM

yhwang · 2021-10-22T01:38:00Z

sorry for the late response, I'm good with the move.

github-actions · 2021-10-22T02:35:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/40464
✔  Done loading data for nodejs/node/pull/40464
----------------------------------- PR info ------------------------------------
Title      meta: move one or more collaborators to emeritus (#40464)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:create-or-update-pull-request-action -> nodejs:master
Labels     doc, meta, tsc-agenda
Commits    1
 - meta: move one or more collaborators to emeritus
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40464
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Danielle Adams 
Reviewed-By: Richard Lau 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Beth Griggs 
Reviewed-By: Myles Borins 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Yihong Wang 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40464
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Danielle Adams 
Reviewed-By: Richard Lau 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Beth Griggs 
Reviewed-By: Myles Borins 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Yihong Wang 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 15 Oct 2021 04:12:13 GMT
   ✔  Approvals: 12
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-780811991
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-780820059
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-785699421
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-784747905
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-784875981
   ✔  - Danielle Adams (@danielleadams) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786199342
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786199444
   ✔  - Сковорода Никита Андреевич (@ChALkeR) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786206079
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786206332
   ✔  - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786210296
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786320852
   ✔  - Yihong Wang (@yhwang): https://github.com/nodejs/node/pull/40464#pullrequestreview-786347207
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1370508576

PR-URL: #40464 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>

Trott · 2021-10-22T05:05:47Z

Landed in 32e2a6f

PR-URL: #40464 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Oct 15, 2021

targos approved these changes Oct 15, 2021

View reviewed changes

Trott approved these changes Oct 15, 2021

View reviewed changes

Trott added blocked PRs that are blocked by other issues or PRs. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Oct 15, 2021

mhdawson mentioned this pull request Oct 18, 2021

Node.js Technical Steering Committee (TSC) Meeting 2021-10-21 nodejs/TSC#1103

Closed

mhdawson requested changes Oct 20, 2021

View reviewed changes

Trott force-pushed the create-or-update-pull-request-action branch from 21775af to b886343 Compare October 20, 2021 16:28

Trott force-pushed the create-or-update-pull-request-action branch from b886343 to 69064fd Compare October 20, 2021 16:31

cjihrig approved these changes Oct 20, 2021

View reviewed changes

aduh95 approved these changes Oct 20, 2021

View reviewed changes

Trott force-pushed the create-or-update-pull-request-action branch from 69064fd to a993e99 Compare October 21, 2021 04:23

mhdawson approved these changes Oct 21, 2021

View reviewed changes

danielleadams approved these changes Oct 21, 2021

View reviewed changes

richardlau approved these changes Oct 21, 2021

View reviewed changes

ChALkeR approved these changes Oct 21, 2021

View reviewed changes

BethGriggs approved these changes Oct 21, 2021

View reviewed changes

MylesBorins approved these changes Oct 21, 2021

View reviewed changes

fhinkel approved these changes Oct 22, 2021

View reviewed changes

yhwang approved these changes Oct 22, 2021

View reviewed changes

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. labels Oct 22, 2021

github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2021

Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2021

Trott force-pushed the create-or-update-pull-request-action branch from a993e99 to 32e2a6f Compare October 22, 2021 05:05

Trott merged commit 32e2a6f into master Oct 22, 2021

Trott deleted the create-or-update-pull-request-action branch October 22, 2021 05:06

targos mentioned this pull request Nov 8, 2021

v17.1.0 release proposal #40758

Merged

BethGriggs mentioned this pull request Nov 26, 2021

v16.13.1 proposal #40974

Merged

1 task

Uh oh!

Conversation

nodejs-github-bot commented Oct 15, 2021

Uh oh!

Trott commented Oct 15, 2021

Uh oh!

Trott commented Oct 15, 2021

Uh oh!

tniessen commented Oct 18, 2021

Uh oh!

targos commented Oct 18, 2021

Uh oh!

Trott commented Oct 19, 2021

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Oct 20, 2021

Uh oh!

Trott commented Oct 20, 2021

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

richardlau commented Oct 20, 2021

Uh oh!

mhdawson commented Oct 20, 2021

Uh oh!

Trott commented Oct 21, 2021

Uh oh!

Trott commented Oct 21, 2021

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

yhwang commented Oct 22, 2021

Uh oh!

github-actions bot commented Oct 22, 2021

Uh oh!

Trott commented Oct 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Trott commented Oct 20, 2021 •

edited

Loading