crypto: remove incorrect constructor invocation#40300
Closed
gc wants to merge 2 commits intonodejs:masterfrom
Closed
crypto: remove incorrect constructor invocation#40300gc wants to merge 2 commits intonodejs:masterfrom
gc wants to merge 2 commits intonodejs:masterfrom
Conversation
Contributor
|
Thanks for the PR. Could you add a regression test please. |
benjamingr
approved these changes
Oct 4, 2021
panva
approved these changes
Oct 4, 2021
Collaborator
Contributor
Author
|
@panva Thank you so much for that! I tried to setup nodejs locally to properly test it, but ran into many issues/errors and didn't have time to continue trying to get it working today. |
panva
pushed a commit
that referenced
this pull request
Oct 5, 2021
PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Member
|
Landed in 28f711b |
Member
|
Thank you for your contribution @gc! |
Contributor
|
@gc do you mind backporting this PR? It broke the v16.x build. thanks! |
Member
|
@danielleadams i can help, which branch do I base off of and open a PR against? |
targos
pushed a commit
that referenced
this pull request
Oct 9, 2021
PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Member
|
The test failed on v16.x-staging because the diff --git a/test/parallel/test-webcrypto-ed25519-ed448.js b/test/parallel/test-webcrypto-ed25519-ed448.js
index a0d858a4ab..b18f3f9d3b 100644
--- a/test/parallel/test-webcrypto-ed25519-ed448.js
+++ b/test/parallel/test-webcrypto-ed25519-ed448.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals
'use strict';
const common = require('../common');
@@ -11,6 +12,9 @@ const {
webcrypto: { subtle }
} = require('crypto');
+const { internalBinding } = require('internal/test/binding');
+const { DOMException } = internalBinding('messaging');
+
async function generateKey(namedCurve) {
return subtle.generateKey(
{ |
danielleadams
pushed a commit
that referenced
this pull request
Oct 12, 2021
PR-URL: #40300 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line is incorrectly trying to do
throw new lazyDOMException, causing it to throw the wrong error.Reproduction: