Skip to content

src: register external references in the crypto and os bindings#40239

Closed
joyeecheung wants to merge 5 commits intonodejs:masterfrom
joyeecheung:crypto-os-binding
Closed

src: register external references in the crypto and os bindings#40239
joyeecheung wants to merge 5 commits intonodejs:masterfrom
joyeecheung:crypto-os-binding

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Sep 28, 2021

Refs: #38905
Refs: #37476

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 28, 2021
@joyeecheung joyeecheung mentioned this pull request Sep 28, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40106/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 30, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40108/

This was referenced Oct 1, 2021
Open
Open
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40276/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40277/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40284/

@github-actions github-actions bot mentioned this pull request Oct 14, 2021
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 14, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40299/

@github-actions github-actions bot mentioned this pull request Oct 15, 2021
Open
23 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 15, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40313/

@github-actions github-actions bot mentioned this pull request Oct 16, 2021
Open
25 tasks
This was referenced Oct 17, 2021
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40363/

@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 19, 2021

Only one error with pummel/test-fs-watch-non-recursive which seems unrelated to this PR according to nodejs/reliability#91

@joyeecheung
Copy link
Member Author

joyeecheung commented Oct 19, 2021

Landed in 5d0d611...f69a4f6

joyeecheung added a commit that referenced this pull request Oct 19, 2021
@joyeecheung
src: register external references in crypto bindings
3a7b2d7 
PR-URL: #40239
Refs: #38905
Refs: #37476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Oct 19, 2021
@joyeecheung
src: register external references in os bindings
f69a4f6 
PR-URL: #40239
Refs: #38905
Refs: #37476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 20, 2021
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2021
@joyeecheung @targos
src: register external references in crypto bindings
a11f9ea 
PR-URL: #40239
Refs: #38905
Refs: #37476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 23, 2021
@joyeecheung @targos
src: register external references in os bindings
accab38 
PR-URL: #40239
Refs: #38905
Refs: #37476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 24, 2021
Open
Open
@targos targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
@joyeecheung @BethGriggs
src: register external references in crypto bindings
7bb3d43 
PR-URL: #40239
Refs: #38905
Refs: #37476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
@joyeecheung @BethGriggs
src: register external references in os bindings
7a8a6de 
PR-URL: #40239
Refs: #38905
Refs: #37476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
tniessen added a commit to tniessen/node that referenced this pull request May 6, 2023
@tniessen
src: register ext reference for Fingerprint512
bfce258 
Refs: nodejs#40239
tniessen added a commit to tniessen/node that referenced this pull request May 6, 2023
@tniessen
src: register ext reference for Fingerprint512
1b48580 
Refs: nodejs#39809
Refs: nodejs#40239
@tniessen tniessen mentioned this pull request May 6, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request May 8, 2023
@tniessen
src: register ext reference for Fingerprint512
9398ff1 
Refs: #39809
Refs: #40239
PR-URL: #47892
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request May 12, 2023
@tniessen @targos
src: register ext reference for Fingerprint512
9bc5d78 
Refs: #39809
Refs: #40239
PR-URL: #47892
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen @danielleadams
src: register ext reference for Fingerprint512
e1929e1 
Refs: #39809
Refs: #40239
PR-URL: #47892
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@tniessen @MoLow
src: register ext reference for Fingerprint512
33daa89 
Refs: nodejs#39809
Refs: nodejs#40239
PR-URL: nodejs#47892
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@JungMinu JungMinu JungMinu approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung @nodejs-github-bot @jasnell @addaleax @JungMinu