test: fix long path tests to avoid issue #2255#3936
Closed
rsp wants to merge 1 commit intonodejs:masterfrom
rsp:fix-long-path-tests-3
Closed
test: fix long path tests to avoid issue #2255#3936rsp wants to merge 1 commit intonodejs:masterfrom rsp:fix-long-path-tests-3
rsp wants to merge 1 commit intonodejs:masterfrom
rsp:fix-long-path-tests-3
Conversation
mscdex
added
fs
Member
|
@nodejs/testing ... can anyone take a look at this? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test-fs-long-path.js and test-require-long-path.js:
Use os.tmpdir() on Linux if it is readable/writable
but only when the original tests fail
to avoid failing tests on ecryptfs filesystems
See issue #2255 and comments to PR #3925
Change vars to const per advice to PR #3929