Merged
Conversation
Contributor
Author
|
Benchmark CI (misc/startup): https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1033/ Results |
RaisinTen
reviewed
May 29, 2021
marsonya
approved these changes
May 29, 2021
Collaborator
Collaborator
Collaborator
targos
reviewed
Jun 9, 2021
RaisinTen
approved these changes
Jun 9, 2021
Member
RaisinTen
left a comment
There was a problem hiding this comment.
LGTM.
Would it also make sense to correct this comment nearby, by replacing debugs with debugImpls (it was supposed to be done in #33424)?
node/lib/internal/util/debuglog.js
Lines 15 to 17 in 102f98e
Collaborator
antsmartian
approved these changes
Jun 12, 2021
PR-URL: nodejs#38838 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
b152276 to
423ae41
Compare
Contributor
Author
|
Landed in 423ae41 |
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2021
PR-URL: #38838 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
PR-URL: #38838 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #38756.