fs: use assert in fsCall argument checking

[pd4d10]

It seems to be a piece of dead code and could be safely removed

1. The fsCall function is only used within the FileHandle prototype methods
2. The second argument of every call is this, which ensures it's an instance of FileHandle

Updated, see #38519 (comment)

Refs: https://coverage.nodejs.org/coverage-68e6673224365120/lib/internal/fs/promises.js.html#L268

[targos]

The throw can be triggered like this:

import { open } from 'fs/promises'
const handle = await open(new URL(import.meta.url))
handle.read.call({})

[aduh95]

The throw can be triggered like this:

import { open } from 'fs/promises'
const handle = await open(new URL(import.meta.url))
handle.read.call({})

We should have a test for this. @pd4d10 would you be interested in adding this to #38517?

[pd4d10]

The throw can be triggered like this:

import { open } from 'fs/promises'
const handle = await open(new URL(import.meta.url))
handle.read.call({})

OK, get it. Also noticed that the close method uses a class property instead of a prototype method, to bind this and avoid it being changed.

One more question, what if we change all these prototype methods, such as read, write, and others, to class properties? Is there any side effect?

[pd4d10]

We should have a test for this. @pd4d10 would you be interested in adding this to #38517?

OK, that's exactly what I thought.

[jasnell]

Alternatively this could be changed to an assert()

[pd4d10]

Alternatively this could be changed to an assert()

+1. In the user perspective, it's not an argument type error.

Replaced it with an assert expression and also added test cases.

[RaisinTen]

Could you also update the PR title?

[pd4d10]

Could you also update the PR title?

Updated

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37951/ 💚

[jasnell]

Landed in 8231cc4