test: fix flaky test-dns and test-dns-lookup#38282
Merged
Trott merged 1 commit intonodejs:masterfrom Apr 18, 2021
Merged
Conversation
nodejs-github-bot
added
needs-ci
Member
Author
|
Internet CI failing on master: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/20335/ Internet CI passing with this: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/20340/ |
Trott
added
the
flaky-test
Member
Author
|
Fast track to fix node-daily-master? |
Collaborator
cjihrig
approved these changes
Apr 18, 2021
benjamingr
approved these changes
Apr 18, 2021
Ubuntu 16.04 is going to be unsupported after April 2021. Switching Node.js CI to Ubuntu 18.04 for the internet tests resulted in failures in test-dns and test-dns-lookup because it returns server failure/try again on .invalid domain. Add a hostname for testing that will return record not found. PR-URL: nodejs#38282 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
Author
|
Landed in c704faa |
Member
|
I think we should be using one of the reserved (https://tools.ietf.org/html/rfc2606) domains where possible. It looks like |
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Apr 21, 2021
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: nodejs#38286 Refs: nodejs#38282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: #38286 Refs: #38282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Ubuntu 16.04 is going to be unsupported after April 2021. Switching Node.js CI to Ubuntu 18.04 for the internet tests resulted in failures in test-dns and test-dns-lookup because it returns server failure/try again on .invalid domain. Add a hostname for testing that will return record not found. PR-URL: #38282 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
Ubuntu 16.04 is going to be unsupported after April 2021. Switching Node.js CI to Ubuntu 18.04 for the internet tests resulted in failures in test-dns and test-dns-lookup because it returns server failure/try again on .invalid domain. Add a hostname for testing that will return record not found. PR-URL: #38282 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: #38286 Refs: #38282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: #38286 Refs: #38282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: #38286 Refs: #38282 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu 16.04 is going to be unsupported after April 2021. Switching
Node.js CI to Ubuntu 18.04 for the internet tests resulted in failures
in test-dns and test-dns-lookup because it returns server failure/try
again on .invalid domain. Add a hostname for testing that will return
record not found.