Closed
Conversation
The max-len rule often hampers readability rather than enhancing it. Few developers are inconvenienced by lines longer than 80 characters. Let's remove it.
Member
I disagree. Even Prettier recommends 80 characters per line. |
Member
Yu02
approved these changes
Apr 5, 2021
|
I actually think that this is a good idea, or maybe we should keep it as a warning. |
benjamingr
approved these changes
Apr 5, 2021
Member
|
People in favour of max-length - what's the problem with using word-wrapping in the editor? Is that insufficient for readability? |
Member
Author
On the other hand, |
Member
I think not all editors support wrapping at a specific column. Also code does not look the same if line breaks and indentions are missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The max-len rule often hampers readability rather than enhancing it. Few
developers are inconvenienced by lines longer than 80 characters. Let's
remove it.