deps: cherry-pick 68e89fb from v8's upstream by indutny · Pull Request #3779 · nodejs/node

indutny · 2015-11-11T19:36:22Z

Original commit message:

This commit adds some postmortem data that is otherwise unavailable.

I have discovered need in those values when writing:

https://github.com/indutny/llnode

BUG=

Review URL: https://codereview.chromium.org/1436473002

Cr-Commit-Position: refs/heads/master@{#31947}

This postmortem information is useful for both object inspection, and
function's context variables inspection.

cc @nodejs/v8

@nodejs/release I will be more than happy if it will land in as much versions as possible. It is not really a new feature, as I can always polyfill this in my tools.

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{nodejs#31947} This postmortem information is useful for both object inspection, and function's context variables inspection.

bnoordhuis · 2015-11-11T19:43:44Z

deps/v8/tools/gen-postmortem-metadata.py

Curious, what good is that? It's the same as scopeinfo_idx_ncontextlocals.

Oh sh%t. I'll try to fix it during next iteration. It is not used anywhere just yet.

@bnoordhuis do you think it may be a good idea to fix it here before the proper fix will land in V8?

bnoordhuis · 2015-11-11T19:44:26Z

LGTM

indutny · 2015-11-11T19:56:01Z

I have pushed a fix, but we will need to wait for upstream rubber stamp before landing it.

indutny · 2015-11-11T20:02:02Z

Relevant CL: https://codereview.chromium.org/1439763002/

thefourtheye · 2015-11-12T01:46:17Z

deps/v8/tools/gen-postmortem-metadata.py

uinteger32 is intentionally left out or there is no such thing?

There is no such thing.

indutny · 2015-11-12T15:28:01Z

The patch has landed in upstream. Landed in master in 81e32cc cc @nodejs/v8

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. PR-URL: #3779 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

indutny · 2015-11-12T15:28:06Z

Thank you!

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{nodejs#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. PR-URL: nodejs#3779 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. PR-URL: #3779 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) #3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) #3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) #3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) #3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) #3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) #3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) #3755. * v8: Added some more useful post-mortem data (Fedor Indutny) #3779. PR-URL: #3736

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{nodejs#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. PR-URL: nodejs#3779 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{nodejs#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. Ref: nodejs#3779 PR-URL: nodejs#4106 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. Ref: #3779 PR-URL: #4106 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

jasnell · 2016-03-11T02:18:39Z

SGTM for v4

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) nodejs/node#3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) nodejs/node#3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) nodejs/node#3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) nodejs/node#3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) nodejs/node#3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) nodejs/node#3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) nodejs/node#3755. * v8: Added some more useful post-mortem data (Fedor Indutny) nodejs/node#3779. PR-URL: nodejs/node#3736

rvagg · 2016-03-14T02:01:29Z

a little surprised that it's not semver-minor, perhaps because it's within v8 and has a minor reach. +1 for lts if we can really justify semver-patch.

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) nodejs/node#3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) nodejs/node#3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) nodejs/node#3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) nodejs/node#3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) nodejs/node#3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) nodejs/node#3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) nodejs/node#3755. * v8: Added some more useful post-mortem data (Fedor Indutny) nodejs/node#3779. PR-URL: nodejs/node#3736

MylesBorins · 2016-03-17T17:22:54Z

@indutny thoughts on patch vs minor?

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{nodejs#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. Ref: nodejs#3779 PR-URL: nodejs#4106 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>

MylesBorins · 2016-05-17T22:29:04Z

I'm going to go ahead and label this semver minor and include in v4.5.0

indutny · 2016-05-17T23:08:54Z

@thealphanerd sorry, it is minor.

Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. PR-URL: #3779 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * backport 9c927d0f01 from V8 upstream (Myles Borins) #7451 * cherry-pick 68e89fb from v8's upstream (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * ignore negative allocation lengths (Anna Henningsen) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994

Original commit message: deps: cherry-pick 68e89fb from v8's upstream Original commit message: This commit adds some postmortem data that is otherwise unavailable. I have discovered need in those values when writing: https://github.com/indutny/llnode BUG= Review URL: https://codereview.chromium.org/1436473002 Cr-Commit-Position: refs/heads/master@{#31947} This postmortem information is useful for both object inspection, and function's context variables inspection. PR-URL: nodejs/node#3779 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Notable Changes: This list is not yet complete. Please comment in the thread with commits you think should be included. Descriptions will also be updated in a later release candidate. Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post portem data to imrpove object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

Notable Changes: Semver Minor: * buffer: * backport new buffer constructor APIs to v4.x (Сковорода Никита Андреевич) #7562 * backport --zero-fill-buffers cli option (James M Snell) #5745 * build: * add Intel Vtune profiling support (Chunyang Dai) #5527 * repl: * copying tabs shouldn't trigger completion (Eugene Obrezkov) #5958 * src: * add node::FreeEnvironment public API (Cheng Zhao) #3098 * test: * run v8 tests from node tree (Bryon Leung) #4704 * V8: * Add post mortem data to improve object inspection and function's context variables inspection (Fedor Indutny) #3779 Semver Patch: * **buffer**: * ignore negative allocation lengths (Anna Henningsen) #7562 * **crypto**: * update root certificates (Ben Noordhuis) #7363 * **libuv**: * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé) #6796 * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé) #5994 * **npm**: * upgrade to 2.15.9 (Kat Marchán) #7692

indutny added v8 engine Issues and PRs related to the V8 dependency. land-on-v5.x post-mortem Issues and PRs related to the post-mortem diagnostics of Node.js. labels Nov 11, 2015

bnoordhuis reviewed Nov 11, 2015
View reviewed changes

fix

ddc206e

thefourtheye reviewed Nov 12, 2015
View reviewed changes

indutny closed this Nov 12, 2015

indutny deleted the feature/more-postmortem branch November 12, 2015 15:28

targos added v8-backport-to-4.7 labels Nov 18, 2015

rvagg mentioned this pull request Dec 17, 2015

Release 4.2.4 Planning #4321

Closed

MylesBorins added the lts-watch-v4.x label Mar 11, 2016

MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label May 17, 2016

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Jun 1, 2016

MylesBorins mentioned this pull request Jul 12, 2016

Semver-Minor commits in v4.x-staging nodejs/Release#120

Closed

MylesBorins mentioned this pull request Jul 12, 2016

v4.5.0 proposal #7688

Merged

Clemens-git76 mentioned this pull request Apr 16, 2024

[Snyk] Upgrade d3 from 5.16.0 to 7.9.0 Clemens-git76/node#5

Open

Uh oh!

Conversation

indutny commented Nov 11, 2015

Uh oh!

bnoordhuis Nov 11, 2015

Choose a reason for hiding this comment

Uh oh!

indutny Nov 11, 2015

Choose a reason for hiding this comment

Uh oh!

indutny Nov 11, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Nov 11, 2015

Uh oh!

indutny commented Nov 11, 2015

Uh oh!

indutny commented Nov 11, 2015

Uh oh!

thefourtheye Nov 12, 2015

Choose a reason for hiding this comment

Uh oh!

indutny Nov 12, 2015

Choose a reason for hiding this comment

Uh oh!

indutny commented Nov 12, 2015

Uh oh!

indutny commented Nov 12, 2015

Uh oh!

jasnell commented Mar 11, 2016

Uh oh!

rvagg commented Mar 14, 2016

Uh oh!

MylesBorins commented Mar 17, 2016

Uh oh!

MylesBorins commented May 17, 2016

Uh oh!

indutny commented May 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants