doc: fixed typos in doc/api/deprecations.md and doc/api/diagnostics_channel.md#37282
Merged
aduh95 merged 1 commit intonodejs:masterfrom Feb 13, 2021
marsonya:doc-type-fix-3
Merged
doc: fixed typos in doc/api/deprecations.md and doc/api/diagnostics_channel.md#37282aduh95 merged 1 commit intonodejs:masterfrom marsonya:doc-type-fix-3
aduh95 merged 1 commit intonodejs:masterfrom
marsonya:doc-type-fix-3
Conversation
lpinca
approved these changes
Feb 8, 2021
Trott
approved these changes
Feb 8, 2021
Member
|
It's a small thing, and you don't have to worry about it here because it can be fixed (or not) on landing, but our commit messages should use an imperative verb, so "doc: fix typo in foo.md" rather than "doc: fixed typo in foo.md". Normally, I wouldn't say anything, but because it looks like there may be a lot of these, I thought I'd mention it. Thanks for the PRs! |
Member
Author
Thank you for bringing it up. I will keep it in mind. |
PoojaDurgad
approved these changes
Feb 9, 2021
RaisinTen
approved these changes
Feb 9, 2021
RaisinTen
added
the
author ready
HarshithaKP
approved these changes
Feb 9, 2021
PR-URL: #37282 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Contributor
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37282 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37282 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Merged
This was referenced Jan 13, 2023
Open
This was referenced Apr 18, 2023
This was referenced Apr 19, 2023
This was referenced Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in doc/api/deprecations.md -> 'ambiguity' was spelled 'ambigiuty'
in doc/api/diagnostics_channel.md -> 'sensitive' was spelled 'senstive' (twice)