doc: performanceEntry.flags style format#37274
Merged
aduh95 merged 1 commit intonodejs:masterfrom Feb 14, 2021
Merged
Conversation
nodejs-github-bot
added
doc
aduh95
approved these changes
Feb 8, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Good catch! Thanks for the PR 🙏
aduh95
added
the
author ready
RaisinTen
approved these changes
Feb 8, 2021
Lxxyx
approved these changes
Feb 8, 2021
marsonya
approved these changes
Feb 8, 2021
lpinca
approved these changes
Feb 8, 2021
jasnell
approved these changes
Feb 14, 2021
PR-URL: nodejs#37274 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
force-pushed
the
doc-perf-hooks
branch
from
f759c57 to
bcb1964
Compare
Contributor
|
Landed in bcb1964 |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37274 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37274 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
performanceEntry.flagshas a different style in doc.miss ` between the
performanceEntry.flags