Merged
Conversation
nodejs-github-bot
added
meta
richardlau
added a commit
that referenced
this pull request
Feb 5, 2021
Notable changes: The update to npm 6.14.11 has been relanded so that npm correctly reports its version. PR-URL: #37241
richardlau
force-pushed
the
v10.23.3-proposal
branch
from
3eb9b6d to
61174d5
Compare
Collaborator
Collaborator
When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in hash._flush, bypassing safeguards in the JavaScript layer. Calling hash.digest causes EVP_DigestFinal_ex to be called again, resulting in a segmentation fault in the SHA3 implementation of OpenSSL. A relatively easy solution is to cache the result of calling EVP_DigestFinal_ex until the Hash object is garbage collected. PR-URL: #28251 Fixes: #28245 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Backport-PR-URL: #37009 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Member
Author
|
@BethGriggs has raised some questions around the commit metadata (or lack thereof) for the revert commit. I'll open a PR to do the revert and npm reland. |
ruyadorno
approved these changes
Feb 9, 2021
Member
ruyadorno
left a comment
ruyadorno
left a comment
There was a problem hiding this comment.
needs to update the dates, all the rest LGTM 👍
Notable changes: The update to npm 6.14.11 has been relanded so that npm correctly reports its version. PR-URL: #37241
richardlau
force-pushed
the
v10.23.3-proposal
branch
from
61174d5 to
ef1c506
Compare
Collaborator
Member
Author
Date has been updated to today and commits rebased to accommodate #37278. If the CI's come back green I'll attempt to get this out today otherwise it'll slip to tomorrow (and I'll have to adjust the dates again). |
Collaborator
ruyadorno
approved these changes
Feb 9, 2021
richardlau
added a commit
that referenced
this pull request
Feb 9, 2021
Notable changes: The update to npm 6.14.11 has been relanded so that npm correctly reports its version. PR-URL: #37241
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Feb 9, 2021
richardlau
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 9, 2021
targos
removed
npm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2021-02-08, Version 10.23.3 'Dubnium' (LTS), @richardlau
Notable changes
The update to npm 6.14.11 has been relanded so that npm correctly reports its version.
Commits
953a85035d] - crypto: fix crash when calling digest after piping (Tobias Nießen) #28251fe2c98003e] - deps: upgrade npm to 6.14.11 (Ruy Adorno) #371737b7fb43b8a] - Revert "deps: upgrade npm to 6.14.11" (Richard Lau) #372781c6fbd6ffe] - test: add test that verifies crypto stream pipeline (Evan Lucas) #37009