Skip to content

src: put (de)serialization code into node_snapshotable.h/cc#37114

Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung:split-serializable
Closed

src: put (de)serialization code into node_snapshotable.h/cc#37114
joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung:split-serializable

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 28, 2021 •
edited
Loading

So that it's easier to find the corresponding code.

Refs: #36943
Refs: #35711

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 28, 2021
@joyeecheung joyeecheung changed the title src: put (de)serialization code into node_snapshottable.h/cc src: put (de)serialization code into node_snapshotable.h/cc Jan 28, 2021
@joyeecheung
src: put (de)serialization code into node_snapshotable.h/cc
5590b7b 
So that it's easier to find the corresponding code.
@joyeecheung joyeecheung mentioned this pull request Jan 28, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35803/

joyeecheung added a commit that referenced this pull request Feb 5, 2021
@joyeecheung
src: put (de)serialization code into node_snapshotable.h/cc
2e769a9 
So that it's easier to find the corresponding code.

PR-URL: #37114
Refs: #36943
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@joyeecheung
Copy link
Member Author

joyeecheung commented Feb 5, 2021 •
edited
Loading

Landed in 2e769a9

@joyeecheung joyeecheung closed this Feb 5, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@joyeecheung @danielleadams
src: put (de)serialization code into node_snapshotable.h/cc
337b4e7 
So that it's easier to find the corresponding code.

PR-URL: #37114
Refs: #36943
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
@richardlau richardlau mentioned this pull request Jul 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joyeecheung @nodejs-github-bot @juanarbol @targos