src: expose BaseObject::kInternalFieldCount in post-mortem metadata#37111
Closed
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Closed
src: expose BaseObject::kInternalFieldCount in post-mortem metadata#37111joyeecheung wants to merge 1 commit intonodejs:masterfrom
joyeecheung wants to merge 1 commit intonodejs:masterfrom
Conversation
So that the debugger does not have to hard-code the number of internal fields of BaseObjects.
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Jan 28, 2021
Collaborator
Collaborator
Trott
approved these changes
Jan 31, 2021
jasnell
approved these changes
Feb 1, 2021
Member
Author
|
Landed in 638fb48 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.
Refs: #36943