[docs] Fix grammar and link to QUIC#36959
[docs] Fix grammar and link to QUIC#36959dandv wants to merge 1 commit intonodejs:masterfrom dandv:patch-2
Conversation
dandv
changed the title
This can be fixed when landing, to avoid having to run another CI just to fix the commit message. |
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM although I wonder if the link should be https://developer.mozilla.org/en-US/docs/Glossary/QUIC rather than Wikipedia.
|
@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection. |
gengjiawen
left a comment
gengjiawen
left a comment
There was a problem hiding this comment.
Whoever land this please fix commit message.
My objection is clear. But also this can be fixed by commiter, I have dismissed my objection with a comment. |
RaisinTen
added
the
author ready
aduh95
dismissed
gengjiawen’s stale review
They dismissed their objection in a comment above.
|
Landed in 75a73c4 |
PR-URL: #36959 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: #36959 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
9 participants
No description provided.