Closed
Conversation
nodejs-github-bot
added
the
lib / src
ronag
force-pushed
the
http-manualStart
branch
from
0fbd1ca to
d1956d1
Compare
ronag
removed
the
lib / src
mscdex
reviewed
Jan 6, 2021
mscdex
reviewed
Jan 6, 2021
mscdex
reviewed
Jan 6, 2021
ronag
force-pushed
the
http-manualStart
branch
3 times, most recently
from
36596e7 to
823908d
Compare
This comment has been minimized.
This comment has been minimized.
ronag
force-pushed
the
http-manualStart
branch
2 times, most recently
from
eae9165 to
f89ab33
Compare
ronag
force-pushed
the
http-manualStart
branch
from
f89ab33 to
bbdf58e
Compare
github-actions
bot
removed
the
request-ci
Collaborator
ronag
force-pushed
the
http-manualStart
branch
from
bbe60f9 to
126dd80
Compare
ronag
added
author ready
Member
Author
targos
removed
the
author ready
mcollina
reviewed
Jul 13, 2021
Collaborator
benjamingr
approved these changes
Jul 14, 2021
ronag
added a commit
that referenced
this pull request
Jul 14, 2021
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: #36820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
Author
|
Landed in 8306051 |
targos
pushed a commit
that referenced
this pull request
Jul 17, 2021
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: #36820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Member
|
Is it intended to be public API? In that case it should be documented and this PR is semver-minor. |
Member
|
@ronag ^ |
ronag
added
the
semver-minor
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Jul 29, 2021
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: nodejs#36820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
Author
|
Added don't land tags for now due to ongoing discussions. |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 1, 2021
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: nodejs#36820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
|
Where are the discussions happening? |
Member
|
Oh I see, it was reverted and implemented differently in #39589 |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2021
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: nodejs#36820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2021
Adds readableDidRead to streams and applies usage to http, http2 and quic. PR-URL: nodejs#36820 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds readableDidRead to streams and applies usage to http.