Conversation
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`.
|
@nodejs/documentation |
|
I would prefer changing
|
The
Even thought MDN and wikipedia specify the inheritance is for an object or class, but for future JavaScript usage, the inheritance would look like: class Foo extends Bar {
...
}And we cannot do like this: (new Foo) extends Bar;
// syntax errorSo, I think to keep the consistence with ES6's syntax, we should change the description to: inheritance should only on classes.
100% agreed on changing from |
|
Closing because of inactivity, thank you guys |
|
If you wish to re-open, the last version you had LGTM. |
|
Really? I thought you rejected it :-( |
|
I had some comments, and you addressed them. I thought it was fine. Sorry I didn't make that clear! Maybe let's see if we can get one more person's opinion? /cc @nodejs/documentation |
|
Lol, never mind, REOPEN-ing, thank you :-) |
doc/api/errors.markdown
Outdated
There was a problem hiding this comment.
Nit: The scare quotes around exception are unnecessary IMO. Since we're editing nearby text, maybe this is a good opportunity to remove them. Totally optional, feel free to ignore, I'm fine with the change as is.
|
@Trott Agreed and fixed :-) |
|
LGTM. Unless someone else has an objection, I'll land this on Monday UTC. (It's a major holiday in the U.S. today, so I want to give some time for people to chime in, since the issue was dormant for so long. Thanks for your patience!) |
|
LGTM |
|
LGTM too. 👍 |
|
LGTM |
|
Landed in 2fb34b6 |
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: #3658 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: nodejs#3658 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
8 participants
A value shouldn't be described as doing inherit from some class, more
strictly, the value is an instance of the class
Error.Just read the new documentation of Node.js, and raise this up :-)
/cc @chrisdickinson