lib: restate the code to use primordials

[PoojaDurgad]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[aduh95]

Can you also replace those please:

node/lib/internal/validators.js

Line 66 in f28715d

if (!octalReg.test(value)) {

node/lib/internal/validators.js

Line 201 in f28715d

(typeof port === 'string' && port.trim().length === 0) ||

[PoojaDurgad]

Benchmark Cl : https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/765/

[PoojaDurgad]

@aduh95 - yes, I modified the changes. PTAL

[Trott]

Commit message should indicate where we are using more primordials. Maybe this?

lib: use more primordials in shared validators

[Trott]

Removed author ready label. It should not be added until a full CI is started.

[Trott]

Benchmark Cl : https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/765/

It looks like the benchmark is for assert which is the default in the Jenkins interface. I could be wrong, but I don't think that's the benchmark we want here. I don't believe that uses the internal validators. I'm not sure what benchmark would be impacted by this code, but benchmark/util/type-check.js is worth a lock. If it is a relevant benchmark, then change assert to util in the Jenkins form and put type-check in the filter field.

[Trott]

LGTM if no benchmark or CI issues.

[PoojaDurgad]

@Trott - Thanks for the review. without fully knowing it, I left the default values in jenkins interface.
Benchmark Cl: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/779/

[PoojaDurgad]

Benchmark result : https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/782/console

                                                                                                       confidence  improvement  accuracy (*)   (**)  (***)
14:31:32  util/type-check.js n=100000 argument='false-object' version='js' type='ArrayBufferView'                       -2.78 %       ±5.30% ±7.08%  ±9.28%
14:31:32  util/type-check.js n=100000 argument='false-object' version='js' type='TypedArray'                            -1.37 %       ±3.50% ±4.66%  ±6.07%
14:31:32  util/type-check.js n=100000 argument='false-object' version='js' type='Uint8Array'                      *      6.74 %       ±5.52% ±7.37%  ±9.66%
14:31:32  util/type-check.js n=100000 argument='false-object' version='native' type='ArrayBufferView'                    3.49 %       ±4.72% ±6.28%  ±8.18%
14:31:32  util/type-check.js n=100000 argument='false-object' version='native' type='TypedArray'                         0.36 %       ±4.63% ±6.15%  ±8.01%
14:31:32  util/type-check.js n=100000 argument='false-object' version='native' type='Uint8Array'                        -2.16 %       ±4.36% ±5.80%  ±7.55%
14:31:32  util/type-check.js n=100000 argument='false-primitive' version='js' type='ArrayBufferView'                    -3.30 %       ±5.65% ±7.52%  ±9.79%
14:31:32  util/type-check.js n=100000 argument='false-primitive' version='js' type='TypedArray'                         -2.13 %       ±4.46% ±5.94%  ±7.73%
14:31:32  util/type-check.js n=100000 argument='false-primitive' version='js' type='Uint8Array'                         -1.96 %       ±4.35% ±5.79%  ±7.53%
14:31:32  util/type-check.js n=100000 argument='false-primitive' version='native' type='ArrayBufferView'                -5.02 %       ±6.94% ±9.23% ±12.02%
14:31:32  util/type-check.js n=100000 argument='false-primitive' version='native' type='TypedArray'                      1.92 %       ±5.01% ±6.67%  ±8.69%
14:31:32  util/type-check.js n=100000 argument='false-primitive' version='native' type='Uint8Array'                      4.72 %       ±5.51% ±7.34%  ±9.58%
14:31:32  util/type-check.js n=100000 argument='true' version='js' type='ArrayBufferView'                               -1.16 %       ±5.77% ±7.69% ±10.03%
14:31:32  util/type-check.js n=100000 argument='true' version='js' type='TypedArray'                                     2.32 %       ±6.53% ±8.69% ±11.33%
14:31:32  util/type-check.js n=100000 argument='true' version='js' type='Uint8Array'                                    -0.87 %       ±4.90% ±6.52%  ±8.48%
14:31:32  util/type-check.js n=100000 argument='true' version='native' type='ArrayBufferView'                           -3.66 %       ±4.93% ±6.56%  ±8.53%
14:31:32  util/type-check.js n=100000 argument='true' version='native' type='TypedArray'                                 1.97 %       ±4.33% ±5.77%  ±7.53%
14:31:32  util/type-check.js n=100000 argument='true' version='native' type='Uint8Array'                                 0.84 %       ±4.62% ±6.15%  ±8.00%
14:31:32 
14:31:32 Be aware that when doing many comparisons the risk of a false-positive
14:31:32 result increases. In this case there are 18 comparisons, you can thus
14:31:32 expect the following amount of false-positive results:
14:31:32   0.90 false positives, when considering a   5% risk acceptance (*, **, ***),
14:31:32   0.18 false positives, when considering a   1% risk acceptance (**, ***),
14:31:32   0.02 false positives, when considering a 0.1% risk acceptance (***)

is this performance result within allowable limits?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35046/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35063/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35127/

[aduh95]

Landed in 0538749