test: fix comment misspellings of transferred#36360
Merged
Trott merged 1 commit intonodejs:masterfrom Dec 7, 2020
Merged
Conversation
nodejs-github-bot
added
addons
2 tasks
danbev
approved these changes
Dec 3, 2020
Contributor
danbev
left a comment
danbev
left a comment
There was a problem hiding this comment.
Sorry, I only searched the src directory and should have searched everything.
Member
Author
I suppose. On the other hand, I'm OK with having |
github-actions
bot
removed
the
request-ci
Collaborator
himself65
approved these changes
Dec 3, 2020
aduh95
approved these changes
Dec 3, 2020
watilde
approved these changes
Dec 3, 2020
richardlau
approved these changes
Dec 3, 2020
Collaborator
Collaborator
Collaborator
PR-URL: nodejs#36360 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Member
Author
|
Landed in 5122456 |
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36360 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
PR-URL: nodejs#36360 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36360 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes