src: remove some duplication in DeserializeProps#36336
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove some duplication in DeserializeProps#36336danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
Collaborator
himself65
approved these changes
Dec 1, 2020
Trott
approved these changes
Dec 2, 2020
richardlau
approved these changes
Dec 2, 2020
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Please fix the "dupclication" typo in the commit message on landing.
This commit introduces a new macro to reduce som code duplication in Environment::DeserializeProperties.
danbev
changed the title
danbev
force-pushed
the
env-deserialize-macro
branch
from
8bbd7dc to
5728820
Compare
danbev
added a commit
that referenced
this pull request
Dec 4, 2020
This commit introduces a new macro to reduce som code duplication in Environment::DeserializeProperties. PR-URL: #36336 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Contributor
Author
|
Landed in ff28ab7. |
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
This commit introduces a new macro to reduce som code duplication in Environment::DeserializeProperties. PR-URL: #36336 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
This commit introduces a new macro to reduce som code duplication in Environment::DeserializeProperties. PR-URL: nodejs#36336 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new macro to reduce som code duplication in
Environment::DeserializeProperties.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes