test: fix flaky test-http2-respond-file-error-pipe-offset#36305
Merged
Trott merged 0 commit intonodejs:masterfrom Dec 7, 2020
Merged
test: fix flaky test-http2-respond-file-error-pipe-offset#36305Trott merged 0 commit intonodejs:masterfrom
Trott merged 0 commit intonodejs:masterfrom
Conversation
Trott
changed the title
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Can't we use a UNIX socket instead? |
Member
Author
I'm under the impression that the test is specifically for an issue involving pipes, but I could be wrong. /ping @addaleax |
addaleax
approved these changes
Dec 2, 2020
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I think this is fine, as would be using a socket. The important thing is that the target file is not seekable.
Collaborator
Collaborator
Collaborator
Collaborator
Member
Author
|
Landed in f178c5a |
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
Fixes: nodejs#35881 PR-URL: nodejs#36305 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #35881
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes