tools: enforce use of single quotes in editorconfig#36020
Closed
aduh95 wants to merge 1 commit intonodejs:masterfrom
Closed
tools: enforce use of single quotes in editorconfig#36020aduh95 wants to merge 1 commit intonodejs:masterfrom
aduh95 wants to merge 1 commit intonodejs:masterfrom
Conversation
github-actions
bot
removed
the
request-ci
Collaborator
Trott
approved these changes
Nov 7, 2020
aduh95
added
the
author ready
lpinca
approved these changes
Nov 12, 2020
lpinca
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in f6ada62...ba73f93 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
PR-URL: #36020 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
PR-URL: #36020 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #36020 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #36020 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #36020 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid text editor to replace quotes by double quotes.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes