doc: update core-validate-commit link in guide#35938
Closed
watilde wants to merge 1 commit intonodejs:masterfrom
Closed
doc: update core-validate-commit link in guide#35938watilde wants to merge 1 commit intonodejs:masterfrom
watilde wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
github-actions
bot
removed
the
request-ci
Collaborator
codebytere
approved these changes
Nov 3, 2020
richardlau
approved these changes
Nov 3, 2020
watilde
added
the
author ready
Trott
approved these changes
Nov 3, 2020
cjihrig
approved these changes
Nov 3, 2020
mmarchini
approved these changes
Nov 3, 2020
lpinca
approved these changes
Nov 3, 2020
tniessen
approved these changes
Nov 4, 2020
watilde
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in c5477be...456b4e1 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 6, 2020
PR-URL: #35938 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35938 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #35938 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35938 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35938 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core-validate-commitrepository had been migrated under nodejs org.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes