deps: upgrade to cjs-module-lexer@1.0.0#35928
Closed
guybedford wants to merge 2 commits intonodejs:masterfrom
Closed
deps: upgrade to cjs-module-lexer@1.0.0#35928guybedford wants to merge 2 commits intonodejs:masterfrom
guybedford wants to merge 2 commits intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
lib / src
Contributor
Author
|
Requesting a fast track here again. |
MylesBorins
added
the
fast-track
Contributor
|
Can we please fast track? |
bmeck
approved these changes
Nov 2, 2020
targos
approved these changes
Nov 2, 2020
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
LGTM with an update of the link in the docs
Collaborator
Contributor
Author
|
Landed in a5f99b8. |
guybedford
added a commit
that referenced
this pull request
Nov 2, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35928 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to cjs-module-lexer@1.0.0, with some final getter refinements to fix #35859.
To explain the getter handling story here:
Object.definePropertyonce called to set a value property, which was then being detected as one of these safe properties.Thus this update includes the fix at nodejs/cjs-module-lexer#29 which adds unsafe getter tracking to specifically mark unsafe getters and never emit them even if they later have safe getter forms.
I've verified this fixes the test case from #35859.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes