deps: update to cjs-module-lexer@0.5.2#35901
Closed
guybedford wants to merge 1 commit intonodejs:masterfrom
Closed
deps: update to cjs-module-lexer@0.5.2#35901guybedford wants to merge 1 commit intonodejs:masterfrom
guybedford wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
Contributor
Author
|
I'd like to request a fast track for this PR. |
Collaborator
Contributor
Author
|
Ping @nodejs/modules-active-members for review. |
Contributor
I'm still able to reproduce the related issue when applying the patch from this PR… Am I missing something? |
guybedford
force-pushed
the
lexer-update
branch
from
5d62a28 to
29056dd
Compare
guybedford
changed the title
Contributor
Author
|
@aduh95 thanks so much for checking this, I've updated the PR to a 0.5.2 supporting named getter functions, it's working now for the example I can confirm. |
Collaborator
Contributor
|
Yes, I can confirm the new version solves the issue 🎉 |
aduh95
approved these changes
Oct 31, 2020
Trott
approved these changes
Nov 1, 2020
guybedford
added a commit
that referenced
this pull request
Nov 1, 2020
PR-URL: #35901 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Contributor
Author
|
Landed in 5735525. |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35901 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35901 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35901 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35901 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35901 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to cjs-module-lexer@0.5.2, with the patches to improve the getter detection over the previous global opt-out of getters to specifically match the exact forms used by the Babel (and RollupJS and other build tool) getter output for reexports in strict conversions, implemented in nodejs/cjs-module-lexer#25 and nodejs/cjs-module-lexer#26.
This fixes the regression in #35893.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes